search

JOML-CI / JOML

A Java math library for OpenGL rendering calculations
MIT License
729 stars 104 forks source link

Kotlin extensions are not involved in the final artifact #320

Closed Peanuuutz closed 2 years ago

Peanuuutz commented 2 years ago

I saw there are two files for kotlin extensions, but when I actually add joml to my project they don't show up. I'm guessing they are not properly set up because kotlin sources require some stand-alone process to build.

httpdigest commented 2 years ago

Thanks for reporting it. I am actually in the midst of migrating the build system from Maven to Gradle. With it, I would then also use the Gradle Kotlin Plugin to build the Kotlin files under src/main/kotlin alongside the Java files for the JVM target. Actually, those Kotlin files were never really tried/tested, which will change now. So, Kotlin usage should definitely improve a lot in the near future.

httpdigest commented 2 years ago

@Peanuuutz there is now a new 1.10.6-SNAPSHOT on oss.sonatype.org. Can you try it with that new snapshot version?

Peanuuutz commented 2 years ago

@Peanuuutz there is now a new 1.10.6-SNAPSHOT on oss.sonatype.org. Can you try it with that new snapshot version?

Can confirm it's included. 😄

Peanuuutz commented 2 years ago

Also this feature would be nice: componentX() function to vector types like the following:

operator fun Vector2fc.component1(): Float = x()

operator fun Vector2fc.component2(): Float = y()

So that users can do:

val (x, y) = vector
httpdigest commented 2 years ago

I'd gladly accept a pull request from you if you want to make changes to the Kotlin files. I am not that familiar with Kotlin or what's even possible here.