search

JOML-CI / JOML

A Java math library for OpenGL rendering calculations
MIT License
728 stars 104 forks source link

Quaternionf fromAxisAngleDeg angle parameter description discrepancy #342

Closed NicBOMB closed 1 year ago

NicBOMB commented 1 year ago

Quaternionf fromAxisAngleDeg is described as: https://github.com/JOML-CI/JOML/blob/75d60fdad423942d14b2a5c1ca214f51df79bc7a/src/main/java/org/joml/Quaternionf.java#L972-L973 and it does convert angle to radians, but its parameter description reads: https://github.com/JOML-CI/JOML/blob/75d60fdad423942d14b2a5c1ca214f51df79bc7a/src/main/java/org/joml/Quaternionf.java#L982

httpdigest commented 1 year ago

Thanks for pointing it out!