search

JOSM / Mapillary

the Mapillary plugin for the JOSM OpenStreetMap editor
https://wiki.openstreetmap.org/wiki/JOSM/Plugins/Mapillary
GNU General Public License v2.0
40 stars 17 forks source link

Update translatables on Transifex #131

Open tsmock opened 4 years ago

tsmock commented 4 years ago

We need to update translatables on transifex. I know @floscher has access to the JOSM transifex group (https://www.transifex.com/josm/josm/dashboard/), but I don't know about anyone else.

floscher commented 4 years ago

I can look into it. You want to push new translatable strings to transifex, right? Or update the *.po files with the current state from transifex.com

tsmock commented 4 years ago

I want to push some new translatable strings to transifex, yes. Thanks for asking. :)

EDIT: I can already update the translations (I just pulled the sr@latin translation). Also, thanks for the quick reply.

floscher commented 4 years ago

In the .gitlab-ci.yml file there is a job defined that is meant to sync the master branch to transifex for each pushed commit. Unfortunately for some reason it isn't triggered at the moment.

I'll fix that later today, so it can sync again.

tsmock commented 4 years ago

I saw that when I copied the .gitlab-ci file into the MapWithAI plugin (although I commented it out).

I kind of assumed that you had deliberately stopped running pipelines, but I guess I assumed wrong.

floscher commented 4 years ago

As far as I can see, the sync to transifex does not happen, because ./gradlew build fails, because the :spotlessJava task finds errors: https://gitlab.com/JOSM/plugin/Mapillary/-/pipelines/158074122

Then the deploy stage does not run. You could make spotlessJava run through even when it found violations, fix the reported violations or exclude that task from the CI jobs build and java 11 build. Then the upload to Transifex should work again.

tsmock commented 4 years ago

That should be fixed. I just ran it locally -- I also ran gitlab-runner exec docker build for a sanity check, and that succeeded as well.

The pipeline you reference ran two months ago. Since then, only scheduled pipelines have been run. I know there were some changes to mirrored repos in the past few months, so that may have affected the pipeline settings for mirrored repos.

tsmock commented 4 years ago

@floscher : Just an FYI, I modified the CI to use needs instead of dependencies. I also added Java 14 and 15 jobs. For the next scheduled run, I might try (temporarily) removing the except schedule clauses.

tsmock commented 3 years ago

CI should now be good as far as running through all the stages. I'd still like to get the JOSM/plugin/Mapillary repository CI running properly again though, so I can readd the except schedule clauses.

Since the official CI isn't running on PRs, I've temporarily created another Gitlab repo that runs CI. It does not run the sonar lint analysis, unfortunately.

Let me know when you have had a chance to look into why the primary Gitlab repo isn't running on every PR (and tag).

Latest pipelines as of 2020-12-16: JOSM/plugin/Mapillary: https://gitlab.com/JOSM/plugin/Mapillary/-/pipelines/230811087 smocktaylor/Mapillary: https://gitlab.com/smocktaylor/Mapillary/-/pipelines/230897160