Tag Values from imported GeoJSON file include quotes

rjw62 commented 5 years ago

I'm using JOSM version 14760 and GeoJSON plugin version 116 in Windows 7 with Java 1.8.0_201. I'm sure this issue didn't used to be present in some earlier versions, but I don't know when the problem first started. The problem is as follows:

When I load a GeoJSON file in JOSM, that the tag values shown in the JOSM layer (which come from the properties section of the GeoJSON objects) are all surrounding by extraneous double quotes. For example a GeoJSON object with a property value given by "amenity": "bus_station" appears in the JOSM with a key=amenity and value="bus_station" (with the double quotes as part of the value), when it should have value=bus_station.

(When saving such an imported GeoJSON file, the extra double quotes are handled correctly, so for the property above, you'd end up with "amenity": "\"bus_station\"" in the saved GeoJSON file.)

floscher commented 5 years ago

This issue is fixed in https://github.com/JOSM/geojson/commit/8e1c2cc11f1fff9769f3f2ebed7c8467f3cfce62 . Thank you for reporting.

The problem was in this line, where tag values were formatted the same way as they would appear in the JSON file (i.e. strings appeared with quotes): https://github.com/JOSM/geojson/blob/9df03d8d252eaf03cd2fc689c232938e6ce8c6f0/src/main/java/org/openstreetmap/josm/plugins/geojson/GeoJsonReader.java#L249

istvanv-telenav commented 5 years ago

will this be updated in the next JOSM release? I have the latest versions of both JOSM and geojson plugin and this problem still exists Thanks

floscher commented 5 years ago

This will be released the next time a release for the JOSM-plugins in the SVN repository happens.

grigory-rechistov commented 5 years ago

Current (installed two days ago) plugin version 116 available in JOSM still has this problem.

grigory-rechistov commented 5 years ago

According to plugin info, it still loads a version built in December 2018:

10580_Plugin-Url: 52;https://svn.openstreetmap.org/!svn/bc/33089/applications/editors/josm/dist/geojson.jar
12671_Plugin-Url: 55;https://svn.openstreetmap.org/!svn/bc/33565/applications/editors/josm/dist/geojson.jar
12678_Plugin-Url: 87;https://svn.openstreetmap.org/!svn/bc/34579/applications/editors/josm/dist/geojson.jar
Ant-Version: Apache Ant 1.10.5
Author: Ian Dees, matthieun, Larry0ua
Created-By: 1.8.0_202-b26 (Oracle Corporation)
Manifest-Version: 1.0
Plugin-Canloadatruntime: true
Plugin-Class: org.openstreetmap.josm.plugins.geojson.GeoJsonPlugin
Plugin-Date: 2018-12-28T22:12:30.000000Z
Plugin-Description: Allows you to view a GeoJSON file as a layer.
Plugin-Icon: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAIAAADYYG7QAAAACXBIWXMAAA2sAAANrAHvBsZHAAACdmlUWHRYTUw6Y29tLmFkb2JlLnhtcAAAAAAAPHg6eG1wbWV0YSB4bWxuczp4PSJhZG9iZTpuczptZXRhLyIgeDp4bXB0az0iWE1QIENvcmUgNS4xLjIiPgogICA8cmRmOlJERiB4bWxuczpyZGY9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkvMDIvMjItcmRmLXN5bnRheC1ucyMiPgogICAgICA8cmRmOkRlc2NyaXB0aW9uIHJkZjphYm91dD0iIgogICAgICAgICAgICB4bWxuczp4bXA9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC8iPgogICAgICAgICA8eG1wOkNyZWF0b3JUb29sPkFjb3JuIHZlcnNpb24gNC4wLjU8L3htcDpDcmVhdG9yVG9vbD4KICAgICAgPC9yZGY6RGVzY3JpcHRpb24+CiAgICAgIDxyZGY6RGVzY3JpcHRpb24gcmRmOmFib3V0PSIiCiAgICAgICAgICAgIHhtbG5zOnRpZmY9Imh0dHA6Ly9ucy5hZG9iZS5jb20vdGlmZi8xLjAvIj4KICAgICAgICAgPHRpZmY6Q29tcHJlc3Npb24+NTwvdGlmZjpDb21wcmVzc2lvbj4KICAgICAgICAgPHRpZmY6WVJlc29sdXRpb24+ODg5LzEwPC90aWZmOllSZXNvbHV0aW9uPgogICAgICAgICA8dGlmZjpYUmVzb2x1dGlvbj44ODkvMTA8L3RpZmY6WFJlc29sdXRpb24+CiAgICAgIDwvcmRmOkRlc2NyaXB0aW9uPgogICA8L3JkZjpSREY+CjwveDp4bXBtZXRhPgryu68AAAAOhElEQVRYw52Z2XNVV3aH19rTOXe+V7poAiEsgWSBgXZjN+7uVFL9kqRSectD/s08JVWpdpJqV9LdnhjsxoAQAqFZV7rzGfawVh6OJMCNbfB6OHXqTufbvzXtvS4yM/wsY2ZEBACbju/eu99un5u/cF5FcfHi2bvvaurnoQAiInqbr6+tffZgfePF9vzs1O9UHPm02W43mi1ELJb6rljqnVUBRERg3tp89tWDx3/pB//erdn61MbzjUYeL5J98XBtshLPnb/QnJj4GVKpd6E5We7R4f633z151E/HE5cai+ed0ni0LqVc62etdpNapaPDredbn5+fbl9ZvVoqld8JS719uCDCqN9fe/r0ydFgWJ2JVue0lMk4CURaoBFykLpumlXjKGlfGpYmOrsbmzufriwtLixdNiYCZn4LD74VECKmyXhnd2djv9s3dbm0VFcmt3mSWxSIQma5y3IbGAe5b0Sanct1xZ6/Ouge7n37ZP7Zs6urV+cuLkghfjKw8CezzOZ55+Bgp9vvi4gb06zj1NrUec+cBRg6SkAtJ1u94+OvxMylmrw+Ve+nLvEh9ZQQ5s6p4+32aG9lurWyem16dvYkLX4A68eAvPe9Xveo2xuxplqLokpufWKdJc4IkkCJCzUtb7TMSjNi5i92us/6tmr02DlHkDpKvBs5zlgon9d6W3Ouu3J+ZvX69XqjCQDMBEWK/CQQM6VJ1hsMxoEpqlJUzkNIrcsDOIKxp5EnLWCprlfqpqYwEDGDEjj29HyQPzhKDhLrPTmmkQ2p84QKpIzycav34jyOry0tvnflSqVa++t4/z4QM/jgrXVp7rxQXkd54MxRTsESZx5Gnph5tiwv13UzkhzYESMwEQGgUlIg9HN3/zD5pjM6Tn0IZImImAEYFQgsZf3J3ualiFaXL7+3sqqkerNCzOx9kFoRkXPBobQEqQ85UR4wJ0oc2cCtSF6syslIAoAPVHyXiABACGRAJlICgGFnnH++O7p7OB7m3kghEJiBgVkogRCNj2eS/YUSfvDBBxcXFs50Ei+LL8D60/U7978ha6NIMyKFcAoNxNww4sZkdHMymoxVYPB0Ki0DIkopEQUCIKIjsMSzZfPPi81/XZ5capXyQJnn4nnsvQfpqxP93P/7f/7+v/7w2ZvTHhFHw+G/Pdp7mIjb05XZ6Skw5dwF8j6WMF3SE7GUiEQUGPCE5GQlUko+tRPHM1sCAHi/FS9U9deHyf/uDHbHzpiooqF0+DR7cnc9pW7tgpCyePwb6pAS6Ez18yReX+te3++tnGvV2+2pSrmmUCIwMxXpWrC8spIfqF5AxIljZP5kKr4xVfni0H796Ildu7tzdLQft93cedXZkq9//TUgBpQQSkr0uPrHMVWi9KJ9ztVaeWpaRgYQOYSzrnmWIEKIV+FefRcAkIkRWccw6PF3X0SP18a6vjtzlVHI4MhmzJUfBEIABiBmDRQpaUtlURGj8aC39mRisjk12dbGnPmluAohELEI6uKm+AAihhCYOSqVbJbd+fLLP92554SaXLo28tocDPI8Zan4dbHf3DoYQCCmIXy6NXhYiT4617hQ9r1er3vcPddut9ttKWXxsFdrbsF0pg0zR1GECE/X1v/viy8PBqPGzPwoqv/5aHw4GiIQAjARc+Cf7GWFSyWiELg9yveSfLFRujEx0YJ8e/+w0zmanZlqtiaEECGEgr6QpJCHiLTWUordnd0/ff7F+s5+1DpnFuYfDOzWwXFg1shEAMEzSqa3bq7MIADKSqaBvu0ko8z+TTtqNSaCzTa2tqud45mZ6WqlCoj8ikkpjTFHh4df3b377doGVuuTl5ZTwnsHw52xi7SMCk+GAEQsBNBbKPSyrRI7opmyXqmJGcXs3KHNylFUbrSzdLy+sdGs1aanpyrVWuEvY0yaJHfu3v362+8yYRoXF0GoYZILgOtNM11Sz4Z5Pw0SvODADECBOfy0QnyqUNWI1WZ0o1WqaRxmdpQ59JhkNs3ySimK6qV+Ou4/eTrZas7Mziql7t298/nX97uOmtPny3FlnGQUcqUUACPAXCQmpNmN8MXAZ5aRA4HgwPB673pzDAXishb/cKG60ohTT2ngODJayzR3We6dD8NxNhZYKZd1FHcGw16//+Dh481OtzY9167U89xmo0QIabQKJ7EPQsBEWc5WxYThr/eG1gYQwBy+l2bqjfpIgZmnz3bHx3lYaUQliXlggVgpGaNVmtpMoPOhP0yUxInm5M7Tx2vbu/PXfpnldjhKpBBaayIKxIigpDAKDGJq7fpxstHLrPdAzBiY6MfSnl8vwHtp2NsaPeraW+34Uk0DoyNWEmuVyDiZZNY64bw/HiTWkzalYZIJYqMVMQQiBFBKREpoBeTpxSB5fJwcjHKkIJiAQwjIgfiNLjspZUTwSh2PJQLg9ti9GLsrdfPrc6YRKwAkZqOVUsJaP06BhSRgIlJKIlEIDMxSiNgIpQQy9RP7TSfZHqRIFAkmYk8BKABI4FDEEBOhEC+BqJCOAE+JioZliRGhbXBC0nCU2BRr5VJkFDEDQaSVEsID9oQEZCZgYiHAKBVpgQiZ9eMky21oCB4pMciDCx6JmAN5Bkkn3RGYiMQZEDMHIgIqXFYoGJht4IlYfdiOlyqSnR9Z73zo9MexkdVSFGkZGAChEkWlSCOilCiljLQQAq0LaZZnNiCzkXghEpNS74xpa+SH3ksgBOLARMRMFCiEIKVERHWCFwJisc9CiQjAkcBPpssftOKKEoHZKsXSZrlzPuQ2ZHZcjlSlHEtx0ii0FNWSRgou0Hhsc+eBQQtBHLwLwQcBtFTXC1X1vI/r3bGnQCCYiAlCCIECEUkpVVHsiQgRC3EST5rYaKEFaGBm8IwIoRJro2Waucx570KSuTR3JWNaTVPsIBggSW1qPYCQQkIgIucdAZNWYKSQTEwkmJCJAwMGOPUMBT4BAgA67ZMELBFunKtudwd7Y/f77fBNj26fiy/XpDCR804iVssm9irJbZ6jD2GYZI4ht94HHgwz73yhfAieyFNgJdhoqQQ6a58P8odHySjNFDMAMTFQOFGYTyjUWXNGBGJGxH9cmpTc+nTj6P5+v9fZ/+wv649EfuPmzdnZOYEiEEkhaqXISJnmDhGJwTpPxAxotCbm4D0FjwAlLaTE4P3Bfmdne6dPAqK6FsL7IIIHQKJQpEKBQUTqbNPJAMjAzD7QjHb/crl1e7ryx/958HDnyUGp9N2jxySiiWajZCQgEkGkpVEitcKT6EuJCEJKcraoQCUjlMAQfJLa4XC8u7s/HAww+Kbu5lF9qCoZcyDCcLIz5+8XxpPzGqM2cWzWHz/qjdOb11bn/unv16+t7h71K402COz0RpGW9UoUR4YIGDjSqqyjrlbERTHjWKMWgpnTxI6SzOZeCDk3d2FQrhx1DsbDgRjtNrSJ49pAVx2AQAAUZxTqtOogAIOUsL/+4E788fIi7e598/DRufa5ywsLN66Wd44HO4ddieh9OOyNY5PXK7HRKgSSUDQHUTICg5LAWZ4PRmluPTJphSF4IKjWGyaOxv1ut3OQjsdyPGqWKkOfeR8QAcWJJEqcGBJxrVpdqqo7X37V6xz84upqs9nI8nzj+bNWozE7MyMRtjtdKRA9WhcOjofl2FRLBiMEZoFotLAudEdplllm0hKJILgQQmAiiaFejiaqc9VYP3+2mXIWRt0SQL1ZRwBRjMAKhYotaQhhdmbmt6XS3uHx+ubmf/z3H65cWli9vNSeLB8cHoIQpVqjWoqIeJxaK4QnSjKXpFmTigMJjUbZaDgOgaQUSOx98MEDBYmsDSoZ+TzfP97rHHbSNBXA7y2+93e//c2tX96yzkkpX1bq4pgXQtBat5qN2JiJRnXn4HDjxc7G1vbq5cXlxcVGvWpZELOUWK/G1vokdxbQe+yPslGaZ7kT40wgohBM3vsQgpfASgstZPD++PjocH+v1+1562bOTXzy8a3ffHJ7amqqSO3vAwkhCiYANFHUkCIypt1qbu13Hjx5+uTZ5ocfrE60p4wyAOy8M1pqLbLcJxmwUCMhEUBJQS744CEQIxstjFQcwmDQ298/6B53XJ43q9UPb1/99e2Pz1+YR8Qsy4wxUsqier3MsgLo7AAqUERxLIQoRWaq1dg+6Pz56/vW2bm5ufeX36/Va865ECg2Sit0JPoSmSGEQMEjkFSgpZIAo8Hg4GC/0+nkWVKO9M3lq598/NHi4qJUylqrtYqiSCl1Js9LIERU6mVNAgD0HrQWQighK3E8PdHa7XS2drZ3drYXF5eWFpfiUuysY+ZqbEpGAzMya8lKKomYp+nu/t7h/v4oSSLE1UsXf3Xrw5Xl5SiOAxGEEBmji99X6kye75/tXzKdhDwCAEYRSqm0qpbjqcmJrf3Dx4/XNl9sLl9Znp+/aHTEzASsJJRjgaRdbvc7Rwd7e8NhHyhcmm5/dOODq1dXa7UaERWRqpXSxqhTe/Xs+9qOUQihtcZXrDh8FUGnlDLG1Mrl6cnJzZ2de/fuPXv+bPnK8sX5S1IoBEDA46Pjvd29fq8fXNauV39x9f0Pb16fmGwFghMUraWUWisp30Dz5gkaM/tTCyEQUXFfrI8oOOvGWX543H22vd0fDObn5+tR9MXd+2OQx0edPEmbpeja8uJHv7g5NzsbiIrzWvH4IlKVUgXZXw8qfmikx69ynJGdMDETBZvb4Xi8vd/Z3N01SA/WNg4GSd3IlUvzt299uLBwUQjpfZBSFDF7hnJ2fecp7BlWQfPq9XTLEJI06w5Hm8+ff/qHz+ZmZ//2Vx8tLy9rY6y1iCilklIUHj/jKOYTP2dOfVavzrQ504kBOAQGiOLSRKtVkrJaLt28cb1Wq+W5ZeI4josQLKwA+nGUt51Tf0+wMzvRiAgRpRTGRNZa770QAgUivKR5G46fA/Tav0Gn27qTewAggtPh1cuS8e7/UP0/DUkXcMhhe2cAAAAASUVORK5CYII=
Plugin-Icon-Size: 48x48
Plugin-Link: https://wiki.openstreetmap.org/index.php/JOSM/Plugins/GeoJSON
Plugin-Mainversion: 14347
Plugin-Version: 116

matthewdarwin commented 5 years ago

It would be really great to have a fix for this, else I cannot use "update plugins" in JOSM.

JOSM / geojson

Tag Values from imported GeoJSON file include quotes #29