search

JOverseer / joverseer

JOverseer is a desktop application which aims to assist players of the Middle Earth PBM game.
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

NatSell: Changing market doesn't change profit in Order List View #636

Closed GnarlyDave closed 7 years ago

GnarlyDave commented 7 years ago

Have at least the Economy View open and the list of orders. When you show the economy for a nation selling something, and you get a change in the profit made (by changing prices), the economy view shows the change in profit. At the same time, you have that nation sell order shown in the orders list view, which also shows the profit made by the sale. However, any change in market is not reflected in the orders list view until the view is destroyed and recreated. This includes marking a population centre as 'lost', which might reduce the quantity sold.

GnarlyDave commented 7 years ago

The OrderEditorListView isn't spotting that the TeamEconomyView published an EconomyCalculatorUpdate event. Hmm the solution isn't so simple, as the TeamEconomyView is an aggregate of all the sales for the nation. Executive decision approved by Ed is to drop the profit column from the order list view. Rejigging the Team Economy View is on the cards now, to make it more understandable.

GnarlyDave commented 7 years ago

fixed in 82adb8bc91567b0f584624760725ec4f16fa0662