search

JOverseer / joverseer

JOverseer is a desktop application which aims to assist players of the Middle Earth PBM game.
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Game-wide updates silently crashing #681

Closed GnarlyDave closed 5 years ago

GnarlyDave commented 5 years ago

version 1.16.12, create a new game, the map loads in the background, but the dialog stays, and when dismissed, the menu items are still greyed out as if no game has loaded.

GnarlyDave commented 5 years ago

This seems to affect slower computers especially. The internal 'game changed event' is never returning to the caller. I suspect a threading issue. Which means there are likely to be other symptoms.

GnarlyDave commented 5 years ago

Subtle changes that I made recently to add or improve the economy and other updates, half failed to spot when a game changed. Mostly triggered by making your first game CME with only 2 nations, then loading any other type of game...which forced the nation filters to throw null pointer exceptions, which then broke the internal event mechanism telling all the bits of joverseer that something interesting had happened, which then got swallowed because the error handling at that point of joverseer was broken, throwing a masking null pointer exception, which then got thrown away.

Fixed for 1.16.14