JOverseer / joverseer

JOverseer is a desktop application which aims to assist players of the Middle Earth PBM game.
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Warship Strength SNA not always visible or incorrect #702

Open GnarlyDave opened 4 years ago

GnarlyDave commented 4 years ago

Historically SNA 33 was warship strength 4, SNA 34 was strength 5 and SNA50 was warship strength 2.

Within the game engine, SNAs have always had a bonus value associated with them. So in reality the same SNA number can mean different things to different nations. SNAs have internally evolved to be more active in using the bonus value, and SNA34 has been redefined as SNA 33 with bonus of 5, and SNA 50 as SNA33 with a bonus of 2. The game engine understands this, and the actual SNA Descriptions reflect the value of the actual bonus.

JO somehow missed the memo.

One gotcha to keep in mind is the Serialization format for SNAWrapper: adding the bonus is going the change the default serialization code, which will break compatability with existing .jov files. So we need to workout the current code and explicitly set it first. Then have some sensible defaults in code, to cope with old vs new.

There's another issue: that SNAs are far too hidden in JO.....under Edit Nations.... although I did make a JavaFX version of one of the forms as an example of how to do it.