search

JOverseer / joverseer

JOverseer is a desktop application which aims to assist players of the Middle Earth PBM game.
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

UI Freezes/Crashes #722

Closed GnarlyDave closed 1 year ago

GnarlyDave commented 3 years ago

A place to gather reports of screen freezes or crashes, in an effort to spot common circumstances.

Happened a couple of times in Game 88 trying to >issue 840. Totally frozen as soon as I >selected 840 in the Order Editor. Had to shut >down the Java process in Task Manager. >Brad

Unable to duplicate, and the code at that point doesn't have any explicit loops, so not an explicit infinite loop. It could be a UI event loop or race condition, or a bug in some of the 3rd party java code.

GnarlyDave commented 1 year ago

Eventually noticed that it only happened when the order editor preferences; auto-save and auto-draw, were active. This has been tracked down to an infinite loop in the rendering of the 840 order on the map. line 139: https://github.com/JOverseer/joverseer/blob/master/joverseerjar/src/org/joverseer/ui/map/renderers/OrderRenderer.java

The issue came from the fact that if the order isn't given a direction it passes through a "-" parameter, which wasn't handled by the infinite loop. This has been corrected. Thanks Tal.