search

JOverseer / joverseer

JOverseer is a desktop application which aims to assist players of the Middle Earth PBM game.
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Double Agent improvements #744

Closed jonsteer closed 11 months ago

jonsteer commented 11 months ago

Adds a double agent flag to character model. Allows tracking of double agents even when they belong to an ally. Add filter to advanced char view.

GnarlyDave commented 11 months ago

The only reason I'm hesitating to approve this, is that it's changing a domain class, Character. The .jov file is basically default java object serialization with some explicit SerializationIds. So we get compatibility issues to consider and address when classes change. Will previous versions of JO read .jov files created by the new version, without complaint, and will new JO read old .jov files with sensible defaults?

jonsteer commented 11 months ago

Hmm, see what you mean. I’ll do some more testing....

Jon

From: Dave Spring @.> Sent: Wednesday, November 1, 2023 12:22:26 PM To: JOverseer/joverseer @.> Cc: Jon Steer @.>; Author @.> Subject: Re: [JOverseer/joverseer] Double Agent improvements (PR #744)

The only reason I'm hesitating to approve this, is that it's changing a domain class, Character. The .jov file is basically default java object serialization with some explicit SerializationIds. So we get compatibility issues to consider and address when classes change. Will previous versions of JO read .jov files created by the new version, without complaint, and will new JO read old .jov files with sensible defaults?

— Reply to this email directly, view it on GitHubhttps://github.com/JOverseer/joverseer/pull/744#issuecomment-1788864148, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAC4IVLIBAQ5NTKVQS5BRQDYCI5IFAVCNFSM6AAAAAA6HJ5NT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBYHA3DIMJUHA. You are receiving this because you authored the thread.Message ID: @.***>

jonsteer commented 11 months ago

Hi Dave,

I’ve tested opening and saving in different versions and haven’t seen any issues. Obviously, the new functionality only shows up if you re-import at least the latest turn as it is during the import that characters are flagged as double agents. Re-importing with new version then saving and loading in current version works fine. Saving in old version and opening again in new version also works fine, although the double-agent flag is lost so re-import is needed to get them flagged again.

Cheers

Jon

From: Jon Steer @.> Date: Wednesday, 1 November 2023 at 16:40 To: JOverseer/joverseer @.>, JOverseer/joverseer @.> Cc: Author @.> Subject: Re: [JOverseer/joverseer] Double Agent improvements (PR #744) Hmm, see what you mean. I’ll do some more testing....

Jon

From: Dave Spring @.> Sent: Wednesday, November 1, 2023 12:22:26 PM To: JOverseer/joverseer @.> Cc: Jon Steer @.>; Author @.> Subject: Re: [JOverseer/joverseer] Double Agent improvements (PR #744)

The only reason I'm hesitating to approve this, is that it's changing a domain class, Character. The .jov file is basically default java object serialization with some explicit SerializationIds. So we get compatibility issues to consider and address when classes change. Will previous versions of JO read .jov files created by the new version, without complaint, and will new JO read old .jov files with sensible defaults?

— Reply to this email directly, view it on GitHubhttps://github.com/JOverseer/joverseer/pull/744#issuecomment-1788864148, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAC4IVLIBAQ5NTKVQS5BRQDYCI5IFAVCNFSM6AAAAAA6HJ5NT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBYHA3DIMJUHA. You are receiving this because you authored the thread.Message ID: @.***>