Parsing order texts for naming character fails when no name is provided

JOverseer / joverseer

JOverseer is a desktop application which aims to assist players of the Middle Earth PBM game.

BSD 3-Clause "New" or "Revised" License

3 stars 5 forks source link

Closed thorsbro closed 4 months ago

thorsbro commented 6 months ago

Name character commands can be issues without giving a name which will lead to a random name being given to the new character.

If such an order is imported into Joverseer it fails to recognize that no name is given and assign the gender letter "m/f" to the new name instead.

Potential fix, if there is no gender designation and the name is either "f" or "m" joverseer so interpret the name as the gender instead.

GnarlyDave commented 4 months ago

I've refactored the 'order text importing' code and added a number of tests to exercise it. released in version 1.18.11