search

JOverseer / joverseer

JOverseer is a desktop application which aims to assist players of the Middle Earth PBM game.
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Fix combat losses reported on pop centre into #751

Closed jonsteer closed 4 months ago

jonsteer commented 4 months ago

This fixes the estimated losses on the pop centre info box - the percentage losses was been subtracted from 100 when it shouldn't have been

GnarlyDave commented 4 months ago

Thanks for the fix, but it looks like there is another file that you've tweaked... see the failed compile https://ci.appveyor.com/project/GnarlyDave/joverseer/builds/49392350/job/jhkak6o4got83mo3 can you add the file and resubmit

GnarlyDave commented 4 months ago

nevermind - I see that it's a simple fix

Thanks again.

jonsteer commented 4 months ago

Yes, it is, I’ve resubmitted the pull request but just close it. Most of it is the work on combat modifiers… should have created a new branch to fix the losses issue…

Jon

From: Dave Spring @.> Date: Wednesday, 13 March 2024 at 11:17 To: JOverseer/joverseer @.> Cc: Jon Steer @.>, Author @.> Subject: Re: [JOverseer/joverseer] Fix combat losses reported on pop centre into (PR #751)

nevermind - I see that it's a simple fix

Thanks again.

— Reply to this email directly, view it on GitHubhttps://github.com/JOverseer/joverseer/pull/751#issuecomment-1994144618, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAC4IVKXOS4P7LHC3PUE6FDYYAYVLAVCNFSM6AAAAABET43WFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJUGE2DINRRHA. You are receiving this because you authored the thread.Message ID: @.***>