miguelgfierro
commented
1 year ago - [ ] Do a release with release notes following Recommenders or PyTorch.
- [ ] Create a MLOps procedure with tests and GitHub actions. Every time a PR is raised, all the tests need to pass. Follow https://github.com/miguelgfierro/project_template
- [ ] Create a library with the python files that are called by the notebooks, following https://github.com/miguelgfierro/project_template
- [x] Add the plots of EDA to notebooks
- [x] Add a notebook explaining the models you used, explain the math behind it and compare them
- [x] Use a PR per feature instead of a massive PR. See https://github.com/JPBP22/engine/pull/4#discussion_r1136257799
- [x] If you want multiple people to work on the same branch, do it via PRs. See https://github.com/JPBP22/engine/pull/4#discussion_r1136258890
- [x] For each of these pieces of feedback, you can create an issue, then a branch, fix it, do a PR, let other person in the team review, and then merge.
- [x] Some of the commits are not linked to the GitHub account, like the work of Tomas. Make sure you configure your git client. You can follow this guide: https://github.com/Microsoft/Recommenders/wiki/How-to-add-your-name-as-a-contributor-to-the-repo#make-sure-that-your-github-user-is-setup-correctly