feature request: cleaner output

BleakleyMcD commented 8 months ago

(base) /Users/medialab/github/JPC_AV_videoQC-main
≈:≈ python JPC_AV/process_file.py /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv
2024-01-26 11:46:21,402 - config.yaml sourced from /Users/medialab/github/JPC_AV_videoQC-main/config/config.yaml
2024-01-26 11:46:21,406 - command_config.yaml sourced from /Users/medialab/github/JPC_AV_videoQC-main/config/command_config.yaml
2024-01-26 11:46:21,413 - The file name 'JPC_AV_01637.mkv' is valid.
2024-01-26 11:46:21,413 - Video ID matches directory name
2024-01-26 11:46:21,414 - Metadata files will be written to /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637
2024-01-26 11:46:21,414 - Using MediaConch policy JPC_AV_NTSC_MKV_2023-11-21.xml
2024-01-26 11:46:21,414 - running command: mediaconch -p /Users/medialab/github/JPC_AV_videoQC-main/config/JPC_AV_NTSC_MKV_2023-11-21.xml "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" -oc /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_mediaconch_output.csv
2024-01-26 11:46:23,032 - MediaConch policy failed
2024-01-26 11:46:23,033 - running command: exiftool "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" > /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_exiftool_output.txt
2024-01-26 11:46:23,148 - running command: mediainfo -f "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" > /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_mediainfo_output.txt
2024-01-26 11:46:23,830 - running command: ffprobe -v error -hide_banner -show_format -show_streams -print_format json "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" > /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_ffprobe_output.txt
2024-01-26 11:46:24,174 - Processing complete. Output files saved in the directory: /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637
2024-01-26 11:46:24,175 - All specified fields and values found in the Exiftool output.
2024-01-26 11:46:24,175 - Some specified MediaInfo fields or values are missing or don't match:
2024-01-26 11:46:24,175 - 
       metadata field in General: Title does not exist

2024-01-26 11:46:24,175 - 
       metadata field in General: Encoded by does not exist

2024-01-26 11:46:24,175 - 
       metadata field in General: Description does not exist

2024-01-26 11:46:24,175 - 
       metadata field in General: Encoding settings does not exist

2024-01-26 11:46:24,175 - 
       metadata field in General: ORIGINAL MEDIA TYPE does not exist

2024-01-26 11:46:24,175 - No 'encoder settings' in ffprobe output
2024-01-26 11:46:24,175 - All specified fields and values found in the ffprobe output.

(base) /Users/medialab/github/JPC_AV_videoQC-main
≈:≈

Could it look something more like this, including grouping and spacing. Bold is green text, italic is red. Everything else can be normal. I liked the turquoise-ish color you chose for normal.

(base) /Users/medialab/github/JPC_AV_videoQC-main
≈:≈ python JPC_AV/process_file.py /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv

Running the following processes and checks on JPC_AV_01637.mkv

2024-01-26 11:46:21

-- config.yaml sourced from /Users/medialab/github/JPC_AV_videoQC-main/config/config.yaml -- command_config.yaml sourced from /Users/medialab/github/JPC_AV_videoQC-main/config/command_config.yaml

-- The file name 'JPC_AV_01637.mkv' is valid. -- Video ID matches directory name

-- Metadata files will be written to /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637

-- Using MediaConch policy JPC_AV_NTSC_MKV_2023-11-21.xml -- running command: mediaconch -p /Users/medialab/github/JPC_AV_videoQC-main/config/JPC_AV_NTSC_MKV_2023-11-21.xml "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" -oc /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_mediaconch_output.csv -- MediaConch policy failed

-- running command: ffprobe -v error -hide_banner -show_format -show_streams -print_format json "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" > /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_ffprobe_output.txt -- No 'encoder settings' in ffprobe output -- All specified fields and values found in the ffprobe output.

-- running command: exiftool "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" > /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_exiftool_output.txt -- All specified fields and values found in the Exiftool output.

-- running command: mediainfo -f "/Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637.mkv" > /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637/JPC_AV_01637_mediainfo_output.txt

-- The specified MediaInfo fields or values for embedded metadata are below:

metadata field in General: "Title" is empty or does not exist
metadata field in General: "Encoded by" is empty or does not exist
metadata field in General: "Description" is empty or does not exist
metadata field in General: "Encoding settings" is empty or does not exist
metadata field in General: "ORIGINAL MEDIA TYPE" is empty or does not exist

-- Please note that these warnings on metadata are just used to help any issues with your file. If they are not relevant at this point in your workflow, just ignore this. Thanks!

-- Processing complete. Output files saved in the directory: /Users/medialab/Desktop/JPC/20240102/JPC_AV_01637

(base) /Users/medialab/github/JPC_AV_videoQC-main
≈:≈

If the metadata fields do have an associated value stored, please have the script say:

metadata field in General: "Title" has a value of "$VALUE"

eddycolloton commented 8 months ago

Made some good progress on this: https://github.com/JPC-AV/JPC_AV_videoQC/commit/d41d6385ceb38dfd8a6188dc8ffa368a03955bb0

Still need to work on sorting conflicting actual/expected values output. For now it is still the old format: Some specified [metadata tool] fields or values are missing or don't match:

[name of field]
Expected: [value]
Actual: [value]

I'll work on getting it down to 1 line, just needs to be disentangled a bit.

All other requested changes to output have been made with the exception of "--" prefix. It's a little tricky to add this as the code is written, I'll explore options.

BleakleyMcD commented 8 months ago

Ok!

The “--“ was just my way of getting around markdown making it an unordered list in GitHub. Any bullet point is fine by me.

On Sun, Jan 28, 2024 at 13:24 eddycolloton @.***> wrote:

Made some good progress on this: d41d638 https://github.com/JPC-AV/JPC_AV_videoQC/commit/d41d6385ceb38dfd8a6188dc8ffa368a03955bb0

Still need to work on sorting conflicting actual/expected values output. For now it is still the old format: Some specified [metadata tool] fields or values are missing or don't match:

[name of field] Expected: [value] Actual: [value]

I'll work on getting it down to 1 line, just needs to be disentangled a bit.

All other requested changes to output have been made with the exception of "--" prefix. It's a little tricky to add this as the code is written, I'll explore options.

— Reply to this email directly, view it on GitHub https://github.com/JPC-AV/JPC_AV_videoQC/issues/14#issuecomment-1913682240, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMZZEODONR7ZLUBH7GJJ2LYQ2JWXAVCNFSM6AAAAABCOJ2CVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGY4DEMRUGA . You are receiving this because you authored the thread.Message ID: @.***>

eddycolloton commented 8 months ago

Output for conflicting actual/expected values is cleaned up: https://github.com/JPC-AV/JPC_AV_videoQC/commit/50e46c24964d53f7a8fb4799c944557b255e858e I had been aggregating the differences in a CSV, but the CSV was parsed based on the old syntax. The differences are aways saved to the log file as well, so the CSV is just a user friendly addition. I'll add the CSV back in once I've sorted out how to do it independent of the phrasing.

eddycolloton commented 7 months ago

ffmpeg stream progress is now printed to the terminal as a percentage, and mediaconch policy rule fails are also printed to the terminal: https://github.com/JPC-AV/JPC_AV_videoQC/commit/9e1e43c2223a6f20caaf98d0abd83914b6e53c39

eddycolloton commented 1 month ago

@BleakleyMcD As of this commit I've finally gone through and revamped all of the new line characters to make spacing more uniform, and coded consistently. Changed some fonts too. Take a look when you can and if you approve I'll close out this issue: https://github.com/JPC-AV/JPC_AV_videoQC/commit/517fcd31d1d8404f71b0a55fc6c3a3388423dbee

JPC-AV / JPC_AV_videoQC

feature request: cleaner output #14