Closed fukusuket closed 1 year ago
Hello, thanks for the excellent tool :) I tried adding a fix that leads to an improvement in the error message.
Upload Event Log File
Time zone
Username
Time Zone
When user does not set Time Zone, the error message is as follows.(Upload failed!)
Upload failed!
It seems that in this case an error message is expected that Please set the time zone of the event logs. as follows.
Please set the time zone of the event logs.
but, the default value for the Time Zone select option was Username as follows.
So I changed the default value in this PR.
After fixing it, I confirmed that the error message is as follows.(Please set the time zone of the event logs.)
and I confirmed that uploading can be performed normally when Time Zone value is set.
I would appreciate it if you could confirm it🙏
Thanks for your pull request!
Thank you for your quick review :)
Hello, thanks for the excellent tool :) I tried adding a fix that leads to an improvement in the error message.
What Changed
Upload Event Log File
:Time zone
select option default valueUsername
toTime Zone
Motivation and Context
When user does not set
Time Zone
, the error message is as follows.(Upload failed!
)It seems that in this case an error message is expected that
Please set the time zone of the event logs.
as follows.but, the default value for the
Time Zone
select option wasUsername
as follows.So I changed the default value in this PR.
Evidence
After fixing it, I confirmed that the error message is as follows.(
Please set the time zone of the event logs.
)and I confirmed that uploading can be performed normally when
Time Zone
value is set.I would appreciate it if you could confirm it🙏