JPCERTCC / LogonTracer

Investigate malicious Windows logon by visualizing and analyzing Windows event log
Other
2.7k stars 441 forks source link

fix: changed utcTime(utcTimeES) select option default value. #129

Closed fukusuket closed 1 year ago

fukusuket commented 1 year ago

Hello, thanks for the excellent tool :) I tried adding a fix that leads to an improvement in the error message.

What Changed

Motivation and Context

When user does not set Time Zone, the error message is as follows.(Upload failed!)

スクリーンショット 2022-12-17 11 17 57

It seems that in this case an error message is expected that Please set the time zone of the event logs. as follows.

but, the default value for the Time Zone select option was Username as follows.

So I changed the default value in this PR.

Evidence

After fixing it, I confirmed that the error message is as follows.(Please set the time zone of the event logs.)

スクリーンショット 2022-12-17 11 24 41

and I confirmed that uploading can be performed normally when Time Zone value is set.

スクリーンショット 2022-12-17 11 33 20

I would appreciate it if you could confirm it🙏

shu-tom commented 1 year ago

Thanks for your pull request!

fukusuket commented 1 year ago

Thank you for your quick review :)