JPCERTCC / LogonTracer

Investigate malicious Windows logon by visualizing and analyzing Windows event log
Other
2.7k stars 441 forks source link

fix: check `timelineTypes` when `all` search clicked in timeline `Graph` view. #130

Closed fukusuket closed 10 months ago

fukusuket commented 1 year ago

Hello, thank you for maintaining the tool :) I found a issue that the graph was not drawn when all clicked in the timeline view, so I fixed it.

What Changed

checking timelineTypes(A flag to identify the table view or graph view) when all clicked in the timeline view.

Motivation and Context

The graph was not drawn when all is clicked(and Graph selected) on the timeline view as follows.

スクリーンショット 2022-12-20 23 24 17

After investigating, I found that createAlltimeline() does not check timelineTypes as follows. https://github.com/JPCERTCC/LogonTracer/blob/v1.5.4/static/js/script.js#L1450-L1453

On the other hand, it is checked in searchTimeline() as follows. https://github.com/JPCERTCC/LogonTracer/blob/v1.5.4/static/js/script.js#L1475-L1479

So, I fixed that checking timelineTypes in createAlltimeline().

Evidence

After fixing it, I confirmed that graph is drawn when all clicked.

スクリーンショット 2022-12-20 23 01 11

I would appreciate it if you could confirm it🙏

shu-tom commented 10 months ago

Thank you!