Closed fukusuket closed 10 months ago
Hello, thank you for maintaining the tool :) I found a issue that the graph was not drawn when all clicked in the timeline view, so I fixed it.
all
checking timelineTypes(A flag to identify the table view or graph view) when all clicked in the timeline view.
timelineTypes
table
graph
The graph was not drawn when all is clicked(and Graph selected) on the timeline view as follows.
Graph
After investigating, I found that createAlltimeline() does not check timelineTypes as follows. https://github.com/JPCERTCC/LogonTracer/blob/v1.5.4/static/js/script.js#L1450-L1453
createAlltimeline()
On the other hand, it is checked in searchTimeline() as follows. https://github.com/JPCERTCC/LogonTracer/blob/v1.5.4/static/js/script.js#L1475-L1479
searchTimeline()
So, I fixed that checking timelineTypes in createAlltimeline().
After fixing it, I confirmed that graph is drawn when all clicked.
I would appreciate it if you could confirm it🙏
Thank you!
Hello, thank you for maintaining the tool :) I found a issue that the graph was not drawn when
all
clicked in the timeline view, so I fixed it.What Changed
checking
timelineTypes
(A flag to identify thetable
view orgraph
view) whenall
clicked in the timeline view.Motivation and Context
The graph was not drawn when
all
is clicked(andGraph
selected) on the timeline view as follows.After investigating, I found that
createAlltimeline()
does not checktimelineTypes
as follows. https://github.com/JPCERTCC/LogonTracer/blob/v1.5.4/static/js/script.js#L1450-L1453On the other hand, it is checked in
searchTimeline()
as follows. https://github.com/JPCERTCC/LogonTracer/blob/v1.5.4/static/js/script.js#L1475-L1479So, I fixed that checking
timelineTypes
increateAlltimeline()
.Evidence
After fixing it, I confirmed that graph is drawn when
all
clicked.I would appreciate it if you could confirm it🙏