Find movement bugs - Githubissues

JPII / NavalBattle

Strategic turn-based naval game.

http://jpii.github.io/NavalBattle

GNU General Public License v3.0

3 stars 3 forks source link

Find movement bugs #207

Closed abauer closed 11 years ago

abauer commented 11 years ago

Find the bugs associated with movement / moveto method

maximusvladimir commented 11 years ago

It has been written: "Thou shall be very careful when modifying moveTo method."

ThomasGaubert commented 11 years ago

Stuff I noticed:

Move limits per turn aren't taken into account yet. (you can move forever)
Narrow bodies of water in which the ship would need to rotate to fit (if at all) are highlighted as okay. It would be difficult to fix this (especially since rotations would be added soon-ish)

abauer commented 11 years ago

hmm you should show me 2), and yes i agree with one, had some questions but the layout is already there.

abauer commented 11 years ago

@maximusvladimir iknow; it had to be done so i wanted to know the side-effects (thus the issue)

maximusvladimir commented 11 years ago

Oh ok.

ThomasGaubert commented 11 years ago

Here's what I was describing: Untitled

abauer commented 11 years ago

basically your saying that you should be able to move there... and it won't move.... i agree, and i knew that was a bug, im going to talk with matt and figure some things out and then i will get back to you...

ThomasGaubert commented 11 years ago

Right it should move and rotate (or just not allow it all assuming it wouldn't rotate).

ThomasGaubert commented 11 years ago

@DarkWarHero What is the status on this?

maximusvladimir commented 11 years ago

@DarkWarHero.

abauer commented 11 years ago

its done...