search

JPII / NavalBattle

Strategic turn-based naval game.
http://jpii.github.io/NavalBattle
GNU General Public License v3.0
3 stars 3 forks source link

fix casting in HUD #226

Closed abauer closed 11 years ago

abauer commented 11 years ago

casting should happen once

abauer commented 11 years ago

ok casting should be complete, but the lag issue still remains; this could be a cause of checking the grid lag or something i have not accounted for. ideally @maximusvladimir could make this super fast if he has time.

(repurpose issue for speeding up the HUD)

maximusvladimir commented 11 years ago

Could you give a code example of this?

maximusvladimir commented 11 years ago

Or even a line number of what you mean?

abauer commented 11 years ago

Example of what the casting issue was; Throughout the update method I would recast display (Entity) to a (MoveableEntity) multiple times; To fix this i created another object move(MoveableEntity) and casted once;

What i would like you to do was look at the update method / entire class and see if you can improve the speed of things happening...

maximusvladimir commented 11 years ago

Ok. I will look when I am ungrounded.

abauer commented 11 years ago

this has kind of been addressed, re-assigning to @maximusvladimir until he takes a look

abauer commented 11 years ago

hud speed has increased considerably; if @maximusvladimir is done we can close this.