search

JPII / NavalBattle

Strategic turn-based naval game.
http://jpii.github.io/NavalBattle
GNU General Public License v3.0
3 stars 3 forks source link

Ships spawning on land and ports not spawning on a dual core processor. #236

Closed smeagle42 closed 11 years ago

smeagle42 commented 11 years ago

Dual core processor computers don't spawn ports and spawn entities on land.

ThomasGaubert commented 11 years ago

I'm fairly sure this doesn't affect all dual core CPUs.

maximusvladimir commented 11 years ago

This has to do with thread execution.

"It's not gonna be an easy fix." - Iron Man 2 quote. Iron Man 2

abauer commented 11 years ago

unless it affects multitudes of users this really shouldn't be a top-priority

ThomasGaubert commented 11 years ago

Might be related to #232

maximusvladimir commented 11 years ago

"Might be related to #232"

It is related to 232.

ThomasGaubert commented 11 years ago

Well okay.

maximusvladimir commented 11 years ago

I didn't intend that to be so harsh. Sorry.

ThomasGaubert commented 11 years ago

It's fine, I didn't take it that way.

ThomasGaubert commented 11 years ago

Zach, check the current.jar and see if it works. It "fixed" my issues on my desktop.

abauer commented 11 years ago

additionally we are going to be distributing via jar so if it works it 'solves' our problem

ThomasGaubert commented 11 years ago

@smeagle42 please answer.

ThomasGaubert commented 11 years ago

Closing for now.

maximusvladimir commented 11 years ago

I just spoke with Mr. Smileg this morning, and he said this issue is still apparent.

ThomasGaubert commented 11 years ago

I'm assuming this means with the .jar?

maximusvladimir commented 11 years ago

Apparently he is having issues with the jar as well.

Can @smeagle42 confirm this?

smeagle42 commented 11 years ago

yes

smeagle42 commented 11 years ago

Redacted

ThomasGaubert commented 11 years ago

Removed inappropriate comment. Please keep it clean.

ThomasGaubert commented 11 years ago

@smeagle42

maximusvladimir commented 11 years ago

The root cause of this is multithreading. The direct cause however, is the miss-assignment of tiles. I will look at shortly.

maximusvladimir commented 11 years ago

I recently committed what I hoped to be a temporary fix. @smeagle42 do you want to test this fix?

ThomasGaubert commented 11 years ago

Obviously not. Moved back and closed.

Reopen if the issue still exists.

maximusvladimir commented 11 years ago

I'm just worried it isn't going to work on Schram's computer.