JPLRepo / Endurance

Kerbal Space Program Endurance Mod
10 stars 4 forks source link

Integrate Reconfig + several updates #30

Closed JadeOfMaar closed 4 years ago

JadeOfMaar commented 4 years ago

Special notice: I've moved and renamed the existing patch configs (KIS, CLS, USI) and I took special care to, as much as possible, respect your original TAC LS patch and to respect its balancing and application to certain Endurance parts. A lot of preference is given to B9 Part Switch, but in the absence thereof, parts will still hold fuel and have some degree of usability.


Endurance Reconfig (from V1.11, KSP 1.9) feature list:

JPLRepo commented 4 years ago

Few things I don't see in the changelog that I wanted to ask about: The MB-25 freight transport module has it's part category changed. The deployable lab has had it's Internalspace model removed and changed to Placeholder. Same goes for the EC-200b command part? The flag part has been hidden/deprecated? Adds science experiments? if a mod is installed WildBlueTools?? Not sure what this multi science box is. cause i don't see it in the changelog. Is this all this WBT and WBI mentioned? in your PR? Not sure I am very keen on adding mod dependencies. But I guess no harm if you don't have it installed. Though I didn't pick up where it doesn't add that part if that mod is not installed.

All these changes need to go into the changelog, and the OP on the forum post will need to be updated too with all these changes and new mod support/dependancies etc.

and I stop there, cause outta time for today. I'm only scratching the surface, it's going to take me several weekends to get through all these changes.

JadeOfMaar commented 4 years ago

Hey JPL. The changelog is supposed to be fleshed out already, but just in case, I've made a small addition or two to hopefully bring it all to the forefront. See: this commit. I had changed the MB-25's category from Utility to Payload because I typically don't see parts that are purely tanks showing up under Utility, and that it may primarily hold things other than propellant so I didn't put it under FuelTank (where, oddly enough, the stock Ore tanks appear).

I don't recall ever seeing IVA portraits during my testing. Then again, I may or may not have ever put kerbals in the crewed ring modules. If I'm somehow in great error, I can undo this (or it may be better if you do so). I've hidden/deprecated the flag, yes. From my experience, that part has always been broken. It has no collider in its idle state so when I pick it from the part catalog, I can't place it anywhere, and when I drop it, I cannot pick it up. If it is dependent on, say, a USI plugin, then I'll never experience that part in working condition as I don't use USI mods at all. The MB-30 multi science box is an all-new part, primarily just a conglomeration of stock experiments, and everything necessary for a drone vessel to deploy itself, and is a new item for the Lander to carry to planetary surfaces.

The dependencies on WBT, and even B9 Part Switch are all soft. I made sure of it. Even my changes to the default fuel loadouts on the parts are set up as a fallback contained in GameData/Endurance/Patches/FuelNoSwitchers.cfg.