Fix version file syntax error

JPLRepo / Endurance

Kerbal Space Program Endurance Mod

10 stars 4 forks source link

Fix version file syntax error #37

Closed HebaruSan closed 4 years ago

HebaruSan commented 4 years ago

The latest release's version file has a syntax error, a comma is missing. This has blocked it from being added to CKAN. This PR fixes it.

Note, @DasSkelett has created a GitHub Action that can validate these files before release and prevent such problems:

https://github.com/DasSkelett/AVC-VersionFileValidator

Tagging @JPLRepo because GitHub notifications are weird for PRs.

JPLRepo commented 4 years ago

ohhhh dang it. I meant to remove that AVC stuff. and forgot. didn't update it either. as for CKAN, that's unfortunate. luckily I don't support CKAN or care about it.

JPLRepo commented 4 years ago

wrong branch as well. closing this one.

HebaruSan commented 4 years ago

wrong branch as well

Oh? GitHub has a setting for the default branch. It's currently set to 'master' in this repo.

HebaruSan commented 4 years ago

didn't update it either

Well someone using your account name did, 14 days ago:

https://github.com/JPLRepo/Endurance/commit/bbe8cbf39bec8df07aad6b129b2d166e336555dc#diff-1b5be1f5de5304fa85b450a425835524

JPLRepo commented 4 years ago

Correct. master is the base branch.

JPLRepo commented 4 years ago

and yes. it auto creates that file from my scripts... I don't actually sit here editing the files myself. But something was wrong with the script for all of my mods a few versions ago. I thought I fixed it, then I thought I removed these files. as they are just an annoyance.

JPLRepo commented 4 years ago

One day when I have spare time I'll go through and update all my scripts again.

HebaruSan commented 4 years ago

Correct. master is the base branch.

Well if you want people to submit to some other branch, maybe say so somewhere? I'm not sure why you mentioned this as if it was something I should have been able to guess.

HebaruSan commented 4 years ago

Anyway I shouldn't be getting all snippy. Thanks for the fix.

JPLRepo commented 4 years ago

Sorry and I should have explained more. Just tough finding the time these days. I don't want the base to be other than master. because it is the base. However, I don't push PRs directly to the base. I'll add comments to the readme's on my repositories.