JPLRepo / ResearchBodies

ResearchBodies is a Kerbal Space Program mod that adds the functionality of tracking bodies to explore them.
13 stars 12 forks source link

ResearchBodiesMMRemoteTech.cfg breaks other mods #48

Closed SirMortimer closed 3 years ago

SirMortimer commented 5 years ago

I assume the file is not supposed to be in the distributed zip any more.

Anyways, Kerbalism users noticed a massive drain of EC with just a single Mk1 pod on the launch pad (12 ec/s), no additional parts, draining the battery within seconds. They didn't have RT installed. Due to some ModuleManager wizardry that is above my pay grade, ResearchBodiesMMRemoteTech.cfg seems to affect the EC usage of the internal ModuleDataTransmitter in the Mk1 pod.

If the file should be in the distribution and currently is missing in the git repository, please consider replacing FOR[RemoteTech] with NEEDS[RemoteTech].

gotmachine commented 4 years ago

Can confirm. The FOR[RemoteTech] is causing all other mods using the proper NEEDS[RemoteTech] in a patch to have that patch wrongly applied. BEFORE/FOR/AFTER is registering the NEEDS keywords.

SirMortimer commented 4 years ago

For clarification, this is the content of that file:

@PART[TrackBodiesTelescope]:FOR[RemoteTech]
{
    %MODULE[ModuleSPU] {
    }

    %MODULE[ModuleRTAntennaPassive] {
        %TechRequired = unmannedTech
        %OmniRange = 3000

        %TRANSMITTER {
            %PacketInterval = 0.3
            %PacketSize = 2
            %PacketResourceCost = 15.0
        }
    }
}

FOR[RemoteTech]really is a problem here. What this apparently does is declare the RemoteTech key that is checked in the NEEDS[RemoteTech] in all patch files. It essentially enables RemoteTech configs for all mods that have any.

This needs to be fixed ASAP.

JPLRepo commented 4 years ago

Will be fixed in next version released once KSP 1.9 is released.

SirMortimer commented 4 years ago

Any chance this could be expedited? We currently have a warning in Kerbalism when ResearchBodies is installed, and are going to release a new version soon. I'd like to remove that warning.

JPLRepo commented 3 years ago

this was fixed already.