search

JPMoresmau / scion-class-browser

Scion part for EclipseFP Class Browser
16 stars 6 forks source link

Build fails with latest `persistent` #6

Closed magthe closed 11 years ago

magthe commented 11 years ago

The latest version of persistent, 1.2.0, has seen quite a few changes in the API and Scion Browser doesn't compile with it (despite the version requirements in the .cabal saying it should ;) )

JPMoresmau commented 11 years ago

As done in https://github.com/JPMoresmau/scion-class-browser/pull/7, just force a constraint to use persistent<1.2... I'm not sure forbidding more recent versions of the library just because they may break the code is a good idea...

magthe commented 11 years ago

This is of course only a stop-gap solution, the proper long-term solution would be to modify the code to use the API of persistent 1.2.x. At the moment this limitation is holding back upgrades to persistent in the various packaging efforts that exist.

JPMoresmau commented 11 years ago

Which packaging efforts are you talking about? If there are such packaging efforts, then the maintainers of the packages should be notified of API breaking changes before they happen, not after.

magthe commented 11 years ago

I'm talking of packaging efforts like ArchHaskell, Debian Haskell Group, etc. The people involved in that are 3rd parties that fairly often find breakages like this one, but they aren't in the position to notify on any breakages before API changes. In this case I seem to have found that an API change in persistent breaks scion browser, and as an effect scion browser is holding back the upgrading of persistent within ArchHaskell. The only people who could have provided any notification of a breakage like this one is the developers of persistent.

JPMoresmau commented 11 years ago

Try scion-browser 0.2.15, should build with persistent >1.2

magthe commented 11 years ago

Indeed it does :)