search

JPStrydom / Crypto-Trading-Bot

Automated Bittrex crypto-currency technical analysis and trading tool
MIT License
301 stars 102 forks source link

Actual profit/loss #11

Closed dr333 closed 6 years ago

dr333 commented 6 years ago

I am not sure if this is an issue or perhaps I am missing something. The profit/loss calculation in the current implementation seems to take into account only the 'quantity' value of the BTC before and after the SELL. It does not account for any corresponding FIAT value and so what appears to be profit may not be an actual profit but rather a loss, say for e.g. if the current price value of BTC (in USD) has dropped. Again, sorry if I have missed something basic here, but would appreciate if someone could validate this. Perhaps this is how the strategy was intended to be but I am not sure.

JPStrydom commented 6 years ago

Yeah the profit looks at coin's BTC value - which is its value on the market it's being traded on. USDT-BTC is a different market all together.

On Fri, 30 Mar 2018, 19:50 dr333, notifications@github.com wrote:

I am not sure if this is an issue or perhaps I am missing something. The profit/loss calculation in the current implementation seems to take into account only the 'quantity' value of the BTC before and after the SELL. It does not account for any corresponding FIAT value and so what appears to be profit may not be an actual profit but rather a loss, say for e.g. if the current price value of BTC (in USD) has dropped. Again, sorry if I have missed something basic here, but would appreciate if someone could validate this. Perhaps this is how the strategy was intended to be but I am not sure.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JPStrydom/Crypto-Trading-Bot/issues/11, or mute the thread https://github.com/notifications/unsubscribe-auth/AYtIsvIbCIhYZ4JCZNfR1MsThuIB2M6hks5tjnBzgaJpZM4TB9QK .

dr333 commented 6 years ago

I see, thank you for clarifying this. Given that, any suggestions on how to account for 'true' profit/loss? The bot currently sells for the configured profit margin but in reality its a loss since the BTC price has dropped significantly.

JPStrydom commented 6 years ago

You'd have to tweak the system to calculate your profit based on the coin -> BTC -> USDT arbitrage.

On Fri, 30 Mar 2018, 20:26 dr333, notifications@github.com wrote:

I see, thank you for clarifying this. Given that, any suggestions on how to account for 'true' profit/loss? The bot currently sells for the configured profit margin but in reality its a loss since the BTC price has dropped significantly.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/JPStrydom/Crypto-Trading-Bot/issues/11#issuecomment-377589944, or mute the thread https://github.com/notifications/unsubscribe-auth/AYtIsvbUEPs15ENL3-pyBYBqixq_intuks5tjnjfgaJpZM4TB9QK .