JPeer264 / node-rcs-core

Rename css selectors across all files
MIT License
37 stars 7 forks source link

Regarding Updating Major Espree Version - #143

Closed rohitpraks closed 3 years ago

rohitpraks commented 3 years ago

Hi, We are using rcs-core in our project which inturn uses espree. The version being used in the latest rcs-core npm is espree@6.2.1 But we need espree@7.3.1 or higher to support optional chaining. Can you please help update it? Is there any reason why espree hasn't been updated recently to the latest major version in rcs-core ? Thanks!

JPeer264 commented 3 years ago

Hey @rohitpraks thanks for your issue. There was no specific reason for it. But I will soon update it to v7+

klimashkin commented 3 years ago

Hi @JPeer264, we are updating the minimal supported version of Safari to >= 13.1, so the optional chaining operator is stopped being compiled by @babel/preset-env as expected (other browsers support it for a while now). And that throws during the rcs-core renaming. That is the reason we need to update espree.

JPeer264 commented 3 years ago

Now the latest ECMA version is used in v3.7.0. I also removed the package lock to ensure you get always the latest minor/patch versions (which is IMO better for libraries like this one)

rohitpraks commented 3 years ago

Thanks a lot. Will try to incorporate it and see how it goes

On Tue, Oct 19, 2021 at 11:19 PM Jan Peer Stöcklmair < @.***> wrote:

Now the latest ECMA version is used in v3.7.0. I also removed the package lock to ensure you get always the latest minor/patch versions (which is IMO better for libraries like this one)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JPeer264/node-rcs-core/issues/143#issuecomment-947363339, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMNTE7IPH7AJZCCQZ2VOIDUHZNQHANCNFSM5GHS6BHQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Regards, -Rohit