JPeer264 / node-rcs-core

Rename css selectors across all files
MIT License
37 stars 7 forks source link

Fix label for attribute #90

Closed X-Ryl669 closed 5 years ago

X-Ryl669 commented 5 years ago

Fix #87. This fixes the missing renaming for label for attribute since this also expect an id (usually from an input)

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling a398e801a419a03dded99b97073531af6f65a00c on X-Ryl669:labelFor into 10ddbd940a58e6594e196d0828066c0d97a07a64 on JPeer264:master.

JPeer264 commented 5 years ago

@X-Ryl669 seems like one test case is failing

X-Ryl669 commented 5 years ago

I don't know why the test failed (maybe you've tested against a different master than mine?). I've rebased on the current master and all tests are good for me.

Unless stated otherwise, I'll rebase on this one for the next PR.