search

JPeer264 / node-rename-css-selectors

📝 Rename css classes and id's in files
MIT License
66 stars 9 forks source link

Hex color is broken #14

Closed klimashkin closed 6 years ago

klimashkin commented 6 years ago

After updating to 1.3.3 color in some classes has become broken after renaming:

.HeaderMenu_item {
    color: #b6c5cc
}
.HeaderMenu_item:focus {
    color: #dfe7ed;
    background-color: #202839
}
.HeaderMenu_item:focus .HeaderMenu_itemContent {
    border-left-color: #00f4f5
}

Renamed into

.lm {
    color: #or
}
.lm:focus {
    color: #dfe7ed;
    background-color: #202839
}
.lm:focus .lg {
    border-left-color: #00f4f5
}
JPeer264 commented 6 years ago

Urgh , sorry about that!

I already started to refactor the css replacing by using css AST, which will be more reliable. On sunday I got more time, so I can implement the rest of it.

klimashkin commented 6 years ago

Sure, take your time!

JPeer264 commented 6 years ago

Alright, the library is now using css AST. I hope the number of this kind of issues will go down now 👍