search

JPeer264 / node-rename-css-selectors

📝 Rename css classes and id's in files
MIT License
65 stars 9 forks source link

Exclude classes with special characters #77

Closed claudia-romano closed 3 years ago

claudia-romano commented 3 years ago

Hi, I'm trying to exclude a class with a special character (e.g .aspect-ratio-1:1) adding it to my package.json file. In the CSS file, I use .aspect-ratio-1\:1 to escape the special character, while in the package.json I do not need to escape it. Not sure if this is the reason, but it does not seem to be working. Should I use a different convention in the package.json file?

Thanks.

JPeer264 commented 3 years ago

Hey @claudia-romano, thanks for your issue. If you want to exclude selectors you should not add . or #. So the correct selector to exclude your css class would be aspect-ratio-1:1.

Which version do you use? So I can give a more detailed answer on how to use it.

claudia-romano commented 3 years ago

Hi, thanks for getting back.

Yes I'm using aspect-ratio1:1: https://www.dropbox.com/s/8s6pmkbopm0wgup/Screenshot%202021-06-23%20at%2008.37.42.png?dl=0

I'm using version 3.2. Thanks

JPeer264 commented 3 years ago

Alright. It seems that there is a bug on rcs-core where it does remove the escaping. I will fix that asap and notify you as soon as it will be fixed.

claudia-romano commented 3 years ago

Thanks!

JPeer264 commented 3 years ago

Sorry for getting back so late. But this should be fixed in v4.0.0. And rcs-core@3.6.4. The only thing which should have been changed is following:

rcs.includeConfig() -> rcs.config.load() rcs.loadMapping() -> rcs.mapping.load() rcs.generateMapping() -> rcs.mapping.generate()

All the rest should have remained the same.

EDIT: Please reopen the issue if you think it's not yet resolved or just come back if you have questions 👍

claudia-romano commented 3 years ago

It's working now. Thanks for your help!