search

JPeer264 / node-semantic-git-commit-cli

A CLI for semantic git commits
https://www.npmjs.com/package/semantic-git-commit-cli
MIT License
147 stars 11 forks source link

Feat/rules #14

Closed aichbauer closed 7 years ago

aichbauer commented 7 years ago

Added Rules:

"rules": {
  "max-char-commit-message": true,
  "max-char": 72,
  "min-char": 10,
  "end-with-dot": false
}

We have a file rulesConfig.js chcking these rules and return true or false.

in promptConfig.js attached to validate.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-2.1%) to 90.741% when pulling 99527bf7f953aeb0ba898da5160e2e0e7d54b079 on feat/rules into 87f95aeab73b864a01790497bef4f981d927cb82 on master.

JPeer264 commented 7 years ago

Maybe we do not need "max-char-commit-message": true,. If either max-char or min-char is set, it is automatically true.

aichbauer commented 7 years ago

Yes that is true, if we set a minimum or a maximum we do not really need a max-char-commit-message

coveralls commented 7 years ago

Coverage Status

Coverage increased (+3.4%) to 96.226% when pulling 140bc96238660ec22434eac8eb59f311b5aa0270 on feat/rules into 87f95aeab73b864a01790497bef4f981d927cb82 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+3.3%) to 96.154% when pulling 161a97239c2ea67175a1110eed82ba0e630dc0db on feat/rules into 87f95aeab73b864a01790497bef4f981d927cb82 on master.