Feat/sgcrc - Githubissues

JPeer264 / node-semantic-git-commit-cli

A CLI for semantic git commits

https://www.npmjs.com/package/semantic-git-commit-cli

MIT License

147 stars 11 forks source link

Feat/sgcrc #3

Closed aichbauer closed 7 years ago

aichbauer commented 7 years ago

Added all types that we discussed.

Add: Files added
Chore: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm) and moving files
CI: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
Docs: Documentation only changes
Feat: A new feature
Fix: A bug fix
Perf: A code change that improves performance
Refactor: A code change that neither fixes a bug nor adds a feature
Style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
Test: Adding missing tests or correcting existing tests

coveralls commented 7 years ago

Coverage increased (+7.8%) to 88.889% when pulling a7d310891884635e13bf3502c05133204193ccc2 on feat/sgcrc into d2e27797f9f9856b64859b471619adda7055cc93 on master.

aichbauer commented 7 years ago

Do we need a type Add:? I think we should always use a more meaningful type.

aichbauer commented 7 years ago

Files added is not really meaningful.

All of the time when you add files you do this because you add docs, features, or some of the other types.

JPeer264 commented 7 years ago

Yap exactly: we got Feat: instead. We can change that

coveralls commented 7 years ago

Coverage decreased (-7.06%) to 78.125% when pulling 7c08852b3904a8c68a42337db41b72cd5b985a52 on feat/sgcrc into b97541b1b78032fd6ef67ce8f17b180b489714ab on master.

coveralls commented 7 years ago

Coverage decreased (-35.2%) to 50.0% when pulling 72fdf1aeaef1dd1b6eef04b59f543f132ad04035 on feat/sgcrc into b97541b1b78032fd6ef67ce8f17b180b489714ab on master.

JPeer264 commented 7 years ago

Thanks @rudolfsonjunior