Feat: show commit msg length (closes #36)

JPeer264 / node-semantic-git-commit-cli

A CLI for semantic git commits

https://www.npmjs.com/package/semantic-git-commit-cli

MIT License

147 stars 11 forks source link

Feat: show commit msg length (closes #36) #40

Closed aichbauer closed 7 years ago

aichbauer commented 7 years ago

Maybe we should add character to the message? Like

The commit message is not allowed to be longer as 72 character, but is 85 character long. Consider writing a body.

Maybe we should also add the current characters to the warning if there are not enough characters. Like

The commit message has to be at least 10 character, but is only 8 character long.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 5f8cd439a506b4f398fe921f622bd76a3e188397 on feat/commitMsgLength into 270d75200a1f04364ecaf8b3dbe06f82ad3694e4 on master.

aichbauer commented 7 years ago

I had the same Problem in another repo.

Looks like its a bug from npm@5.4 only on windows.

Error: EPERM: operation not permitted on npm 5.4 on windows

Downgrading to npm@5.3 could help?

aichbauer commented 7 years ago

So should we also add this to the The commit message has to be at least 10 character text? Should we add the word character or not?

JPeer264 commented 7 years ago

This just occurs on npm@5+?

Yes, I guess adding the word characters may help some people understanding the warning.

aichbauer commented 7 years ago

It is a problem with npm@5.4 with npm@5.3 it should work... I faced the same problem with sgr... and it worked downgrading appveyor to npm@5.3... if no version is specified, appveyor installs the latest version... in this case npm@5.4...

should I downgrade the npm version in the appveyor.yml?

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 9b158dd4afd66db285e1b7048755941ad9ae8fa4 on feat/commitMsgLength into 270d75200a1f04364ecaf8b3dbe06f82ad3694e4 on master.

JPeer264 commented 7 years ago

@aichbauer ya please downgrade, if that is really the issue 👍

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling d345b6ff7ff25215c92724aaa779198cbfa3609f on feat/commitMsgLength into 270d75200a1f04364ecaf8b3dbe06f82ad3694e4 on master.