search

JPeer264 / node-semantic-git-commit-cli

A CLI for semantic git commits
https://www.npmjs.com/package/semantic-git-commit-cli
MIT License
147 stars 11 forks source link

Feat: sgc --retry (closes #65) #69

Closed JPeer264 closed 5 years ago

JPeer264 commented 5 years ago

@aichbauer any suggestions on how to test this?

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling e895ec7e2766e439b590a72c5e180332a06d6e8b on feat/retry into b30c854d6235d4dd2e89ba46a6db026a1e9c6956 on master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 04471dd4d4023636f090f3ad3bd6e121eec0b6d3 on feat/retry into c6f7c0d92ddb74e85687b8d76905875a89234617 on master.

aichbauer commented 5 years ago

Maybe you could make functions that read/writes the retry files and you call it in the cli.js so you have it separated from the cli input and then you could test if this function works properly?

Why are you rewriting some functions with async/await and others not?

JPeer264 commented 5 years ago

Maybe you could make functions that read/writes the retry files and you call it in the cli.js so you have it separated from the cli input and then you could test if this function works properly?

Ya that would work.

Why are you rewriting some functions with async/await and others not?

Because top level await does not exist yet. And wrapping it into an own function would have been a little bit of an overhead. But ya maybe we should stick just either promises or async/await. Could rewrite it.

JPeer264 commented 5 years ago

@aichbauer tests added :+1:

JPeer264 commented 5 years ago

I also did a little refactoring. Unfortunately it is in this PR, as it was too difficult to put it in another PR.

aichbauer commented 5 years ago

I will take a look into it as soon as possible.