search

JPeer264 / node-semantic-git-commit-cli

A CLI for semantic git commits
https://www.npmjs.com/package/semantic-git-commit-cli
MIT License
147 stars 11 forks source link

Feat: custom type (closes #31) #76

Closed JPeer264 closed 5 years ago

JPeer264 commented 5 years ago

(ref: #31)

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.5%) to 99.531% when pulling 862f9a90349eb096815c74ba09c0c962dbf5941a on feat/ustom-type into 54ea475d1d5e75bd6f85c6b4773d0da4f4683d13 on master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling af2d0d44dae94f4be6331d8af8d722ff67f2fe8d on feat/ustom-type into c14a9c34c5168a985b46d7b26cfe6e8938771094 on master.

yordis commented 5 years ago

I would do feat(TICKET-NUMBER) ... instead of creating new types for this.

JPeer264 commented 5 years ago

@yordis this is actually already implemented as scope

JPeer264 commented 5 years ago

Actually what you suggested works too and is also imo much better to read. Unfortunately different companies have different rules - and e.g.: PRE-21: this is a new commit is one of them

yordis commented 5 years ago

@JPeer264 but then people can't assume the tags and other things from the type of the commit.

For the most part, that information is random metadata that you can't rely on.

This is why I think is better to put it as scope (since they kind of are)

JPeer264 commented 5 years ago

I agree to 100% on this.

But still there are projects where this needs to be done (as some of the projects I am working on have this kinda rule). I guess I'll append your suggested method to the readme as well.