search

JPersson77 / LGTVCompanion

Power On and Off WebOS LG TVs together with your PC
MIT License
992 stars 40 forks source link

Adding popular multi-language "restart" phrases? #132

Closed mgutt closed 8 months ago

mgutt commented 1 year ago

For the initial setup the user is forced to select their localized "restart" phrases. Why not collecting some of the popular phrases and built them into the app and totally skip this step to make it even more user-friendly? Finally I think these are "only" 100 to 150 phrases, if all users participate in building a list.

JPersson77 commented 1 year ago

Hi there, yeah it sounds like a good idea but not really sure how to best go about? Setup a google doc, link to it on the github landing page and ask users to contribute? Whaddyathink?

mgutt commented 1 year ago

What about: If the user selects the restart phrase, they will be asked:

Do you like to contribute the phrase to enhance the auto-detection in a future release?
[Open website] [Cancel]

After selecting confirm, a link is opened. This could be a GitHub issue or Google Doc or ...

JPersson77 commented 1 year ago

Hmm yeah that might work! I'll add it to the todo

JPersson77 commented 8 months ago

Started some work on this. Please contribute your input here https://docs.google.com/spreadsheets/d/1SNjYh7kt4aVhHg0ZjI3i96vCeOJZJS73o9Wl-OVEvzk/edit#gid=0

JPersson77 commented 8 months ago

Implemented in v3.5.0. Feel free to reopen the issue as necessary