search

JPro-one / JPro-Platform

Represents the foundation of cross-platform application development, seamlessly integrating the power of JavaFX with the limitless potential of web-based applications running via JPro.
Apache License 2.0
24 stars 3 forks source link

Build with Java8 #2

Open Hugolarson opened 2 years ago

Hugolarson commented 2 years ago

Hello, The web-api is build with java 8. Do you think you can the same with this?

FlorianKirmaier commented 2 years ago

I guess i could, but currently JPro only work with Java11 and above. I think, that should also be changed for the WebAPI.

Can you explain a bit, why that would be an advantage? If i compile for Java8, then i can no longer define the module - which is the new standard.

Hugolarson commented 2 years ago

I understand that JPro only works with Java11 but in my particular case the desktop version of our application runs and compiles on Java8 and need all dependencies java 8 compatible. We have customers that still uses 32 bit windows XP. Since webapi is still compiled with java 8 I thought to give it a shot :)

FlorianKirmaier commented 2 years ago

I think a more elegant solution would be, to just copy the java-file into your project. It's just one file - so updating it should be easy. This way it compiles with your Java-Version, and we can keep the module-stuff in this project.

ctoabidmaqbool commented 2 years ago

I think a separate branch for jdk 8 should be exists there, because many are still using java 8.

However, I somehow switched all my apps to jdk 17. Still using jdk 8 for Android projects. For jPro.one side (jdk 17)