search

JPro-one / JPro

The right place to report about bugs or suggest improvements for JPro.
https://www.jpro.one
9 stars 4 forks source link

Performance issue on client connection #32

Closed neo-expert closed 5 years ago

neo-expert commented 5 years ago

When rendering in webrowser the ui freezes for a short time period if another client is connecting to the same application. You can reproduce it even with the official example: https://demos.jpro.one/tilesfx.html all the animations stuck for a short time, when someone else connects.

FlorianKirmaier commented 5 years ago

A very small freeze is expected, but it seems to be quite longer as it's supposed to be.

FlorianKirmaier commented 5 years ago

This seems to be a problem with the TilesFX sample. The best way to test this is to open the Spinner form JFoenix. When you open the ControlsFX sample, then you can't even see a short freeze. That's how it should be ideally. The application shouldn't block the JavaFX-Thread, then there is no freeze.

neo-expert commented 5 years ago

Interesting thing is: ControlsFX sample does stuck too, but only if someone connects to TilesFX. When the Application does a heavy background work, the UI freezes on all clients.

FlorianKirmaier commented 5 years ago

Correct, We've found a performance-regression in JPro. Your ticket was also useful for finding it.

We've already updated the website. Now the freeze should be only a fourth compared to the old version.

The fix for the problem will probably be announced at the beginning of next week.

I'm closing the ticket now because it's not really a bug. These freezes can be avoided by not blocking the JavaFX-Thread during the start of an application.

neo-expert commented 5 years ago

Yeah, but it is still strange, that you can crash another client session just by refreshing the page. I can do it every time on the officital examples.