JQChong / pe

0 stars 0 forks source link

Limitation of plantUML is not stated in some of the sequence diagrams #13

Open JQChong opened 3 years ago

JQChong commented 3 years ago

Preferably, the limitation should be mentioned under every sequence diagram, because strictly speaking having lifeline extended after the cross mark is a notational error.

image.png

nus-pe-bot commented 3 years ago

Team's Response

Hi, thanks for pointing this out, however, as stated in the module website: UML notation variations caused by the diagramming tool: Can be rejected if not contradicting the standard notation (as given by the textbook) i.e., extra decorations that are not misleading.

I believe that argument for this is that there is a lifeline that extends beyond AddSessionCommand due to the limitation of plantUML. However, as stated, this is basically an extra line and we have already put an X to indicate the end of life of the the command as per the UML standard. Hence this should not be a bug.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The lifeline here depicts whether the instance is still alive as the time progresses, if the instance has been deleted, then the lifeline should terminate after the X. Since this is a limitation due to PlantUML, it should still be mentioned explicitly.