nus-pe-bot
commented
3 years ago Team's Response
No response provided.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
delete_student 99999999999999999999999999999 returns invalid command
Expected: delete_student 99999999999999999999999999999 returns invalid index.
Actual: The command above returns invalid command instead, even though 99999999999999999999999999999 is a positive integer.
[original: nus-cs2103-AY2021S2/pe-interim#277] [original labels: severity.Medium type.FunctionalityBug]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
It is true that 99999999999999999999999999999 is a positive integer, but we do not concern ourselves with those cases as mentioned in the DG under the "Non-functional requirements" we will guarantee the normal operation of 100-200 students.
Thank you for your feedback!
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [x] I disagree
Reason for disagreement: The nature of the issues are slightly different in the sense that in the original issue, the team did not handle such errors consciously, i.e. the error was handled back in AB-3. In this case however, the error was explicitly handled since it is rather clear to me that the team is the one phrased the error message in this manner.
:question: Issue response
Team chose [response.NotInScope]
- [x] I disagree
Reason for disagreement: It is true that the application will probably not handle such a large number of contacts (there aren't that many people in the world anyways), but again it is clear that the team consciously phrased the error message in this way, because in usual cases the system will return invalid command format.
:question: Issue type
Team chose [type.FunctionalityBug]
Originally [type.FeatureFlaw]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
It would be better if the application could provide a range of indices that are valid instead of stating that the index supplied is not a non-zero unsigned integer.