JRBusiness / JMR-OutLook-Creator

A simple selenium script to mass create outlook account without having to input all kind of information, the bot handle it for you!
GNU General Public License v3.0
28 stars 11 forks source link

incomplete #6

Open ErrorErrorSystemNotReady opened 1 year ago

ErrorErrorSystemNotReady commented 1 year ago

The code seems to be incomplete and has missing parts after the line self.driver.find_element_by_id("Country").... There is no closing bracket and no more code after that. It's likely that the code was truncated or incomplete. However, I can review the code above that line and provide feedback on it.

Here are a few issues I have noticed:

The chrome_options are being modified after the webdriver.Chrome() is called. This may lead to unexpected behavior, and the options should be set before creating the driver instance.
The page_has_loaded() function always returns True, regardless of whether the page has actually loaded or not. This function needs to be fixed to properly check if the page has loaded.
The is_visible() function could be improved by using a more descriptive name, and by using a better selector than just the ID. Additionally, it should catch exceptions more specifically rather than just TimeoutException.
The get_proxy() function may raise an IndexError if the proxies list is empty, and there is no error handling for this case.