search

JRG-Developer / AutoLayoutTextViews

AutoLayoutTextViews subclasses UITextView and adds placeholder text, auto resizing, and keyboard avoiding functionality.
Other
19 stars 6 forks source link

CocoaPod for 1.1.1 needs to be pushed to trunk #1

Closed AnthonyMDev closed 10 years ago

AnthonyMDev commented 10 years ago

I made a bug fix and created a version 1.1.1.

Podspec is updated, but I don't have privileges to push this to your trunk. Can this get pushed please?

Thanks

JRG-Developer commented 10 years ago

Previous comment (now deleted) was intended for AutoLayoutCells repo... please ignore.

AnthonyMDev commented 10 years ago

The reason for this change was that, when being used with 'AutoLayoutCells' the constraint was being updated before the sizing cell could calculate the size of the other cells, causing undesired behaviors where all cells with the same identifier as the cell would either grow or none of them would grow and the text field would be cut off.

JRG-Developer commented 10 years ago

The problem I have with this commit is that it seems to not allow the ALAutoResizingTextView to be used outside of a table view... see the demo... thoughts?

JRG-Developer commented 10 years ago

Please try the latest development commit c9bb847, does this work?

JRG-Developer commented 10 years ago

Perhaps it would be good to have this included in the demo project (e.g. UITableViewController subclass that has simple cells with ALAutoResizingTextView in them?)

JRG-Developer commented 10 years ago

Can you add this, Anthony, as you seem to have it as an existing need and are most familiar with it?

AnthonyMDev commented 10 years ago

Looking into this now

JRG-Developer commented 10 years ago

I broke some tests, but I'm fixing them now...

AnthonyMDev commented 10 years ago

Your changes seem to work just fine for me in a table view @JRG-Developer. I don't see that it is not working when it's not in a tableview though.

One change I'm going to make. Apple documentation states that you should call [super updateConstraints] at the end of your implementation.

JRG-Developer commented 10 years ago

Yeah, the changes that I've made work outside a table view (your changes only didn't per my testing).

Can you add a new UITableViewController to verify this behavior works in future?

JRG-Developer commented 10 years ago

That is, add to the demo

AnthonyMDev commented 10 years ago

Got it. I'll add that to the demo.

JRG-Developer commented 10 years ago

Great, after that's added, and I've fixed the tests, we'll get this out onto master and pushed to trunk.

:]

AnthonyMDev commented 10 years ago

Demo project completed - #2

New pull request made

JRG-Developer commented 10 years ago

Cool, merged into development.

FYI -- are you only supporting iOS 8.0+? You know that 

self.tableView.rowHeight = UITableViewAutomaticDimension;

is only available from iOS 8.0+, right?

Perhaps since AutoLayoutTextViews will support iOS 7.0+ for a while (maybe 6 more months or more), we should show the manual way of doing this...?

JRG-Developer commented 10 years ago

Hmm... there doesn't seem to be an easy/quick way of doing this... suppose that's why AutoLayoutCells repo exists... :P

I'm leaving it alone for now...

AnthonyMDev commented 10 years ago

Yes, I know that the demo project is only supporting iOS8. The only other way to do this would be to use AutoLayoutCells.

On Nov 4, 2014, at 6:34 PM, Joshua Greene notifications@github.com wrote:

Hmm... there doesn't seem to be an easy/quick way of doing this... suppose that's why AutoLayoutCells repo exists... :P

I'm leaving it alone for now...

— Reply to this email directly or view it on GitHub https://github.com/JRG-Developer/AutoLayoutTextViews/issues/1#issuecomment-61751005.

JRG-Developer commented 10 years ago

I'm considering adding IBInspectable to some properties... do you know if this is backwards compatible to iOS 7? I don't see why not, but I'm not finding a definitive answer so far...

JRG-Developer commented 10 years ago

Looks like it's adding new xml entries to the storyboard... probably not backwards compatible to iOS 7.0- bummer! I'm omit it...

JRG-Developer commented 10 years ago

Please check out the latest development demo project. I fixed a few things to allow setting placeholder text on the cells.

However, this reveals a peculiar issue-- if you type a lot of text, then delete it, the placeholder text is drawn squished... I'm not happy pushing it with this bug... I'm going to look into this and try to fix soon... check it out, if you find a fix, feel free to commit directly to development (adding tests if needed).

AnthonyMDev commented 10 years ago

Hmmm, odd. I’ll look at this when I get a chance and let you know if I find anything.

On Nov 4, 2014, at 7:00 PM, Joshua Greene notifications@github.com wrote:

Please check out the latest development demo project. I fixed a few things to allow setting placeholder text on the cells.

However, this reveals a peculiar issue-- if you type a lot of text, then delete it, the placeholder text is drawn squished... I'm not happy pushing it with this bug... I'm going to look into this and try to fix soon... check it out, if you find a fix, feel free to commit directly to development (adding tests if needed).

— Reply to this email directly or view it on GitHub https://github.com/JRG-Developer/AutoLayoutTextViews/issues/1#issuecomment-61752906.

JRG-Developer commented 10 years ago

Ok, I think I've fixed this. Please see the latest development commit cc9610b.

It looks like this is working in the demo project; can you make sure this works in your project, Anthony?

If it looks good to you, I'm good with pulling this into master and pushing to CocoaPods trunk.

AnthonyMDev commented 10 years ago

This works for me, so I think we are good to go with it. Thanks Josh!

JRG-Developer commented 10 years ago

Changes pulled into master and pushed to trunk.

:]