search

JRJurman / Letteropend

A gem that exposes Letterboxd data
MIT License
5 stars 1 forks source link

Gem #5

Closed nickserv closed 10 years ago

nickserv commented 10 years ago

Letteropend is now a gem! It exposes a Letteropend library, and has a letteropend CLI.

If you decide to merge this, please double check letteropend.gemspec and update the metadata if necessary.

JRJurman commented 10 years ago

I like the idea of having an actual gem, but as it stands, the functionality of the scripts is very very narrow... I'm building some classes and files to branch out the functionality, and I'd for people to look at those changes, before we formalize what we want this gem to do, and how people should be using it.

I'll tag you guys once I have an actual PR ready to go

kristenmills commented 10 years ago

Ruby doesn't function well when things aren't in gem format. I honestly vote we merge this pull request then update as we go.

JRJurman commented 10 years ago

@nicolasmccurdy is this PR good? I'm giving it a preemptive :+1:, assuming we'll be able to merge the nokogiri/gem-nokogiri stuff (which doesn't pigeonhole people into using these specific use-cases).

nickserv commented 10 years ago

@kristenmills I agree. I think the standard gem format is pretty flexible anyway.

@JRJurman I would call it done (not to say that it wouldn't help to reorganize things in the future though). And yes, merging nokogiri into gem should be fine. In fact, I created the gem-nokogiri branch to start work on this. It's literally just forked off of gem, but with nokogiri merged in, to make future merges easier.

nickserv commented 10 years ago

@JRJurman Are you interested in using this branch? As far as I can tell, the main difference from this and your work is that your changes keep examples in a separate directory, while my branch treats them as subcommands of a command line tool. Are we doing to drop the idea of having a CLI? I like the idea of making the scripts easy to run through a single CLI, but if they're merely documentation for the module it may make sense to close this pull request.

JRJurman commented 10 years ago

I think we should just close the branch... A full fledge CLI would be awesome, but I feel like that should exist as it's own project, which uses this gem

nickserv commented 10 years ago

So am I right in assuming that the examples here aren't the purpose of this project?

JRJurman commented 10 years ago

Yes