JRJurman / automated-ticket-printer

This project is an automated solution to print tickets and items as they get assigned.
MIT License
11 stars 1 forks source link

Make Install Smooth #18

Closed JRJurman closed 8 years ago

JRJurman commented 8 years ago

Making the build process easier and faster for people building the project on their own, or including it as a npm dependency.

Resolves #17

New Dependencies

This includes adding two brand new dependencies:

// before
var aw = require('../lib/ticket-printer').ActivityWatcher;

// now
var aw = require('ticket-printer').ActivityWatcher;

Babel and Node

The babel es2015 preset was removed, and the number of plugins went from 21 to 3. While some may need to be re-introduced, those will be done as that code is written. If it is included with a new watch, hook, or printer, it should be added as an optional dependency.
This increases the install and build speed incredibly, having less dependencies to grab when starting the project, and faster builds by ignoring es5 restrictions.
Older versions of Node may fail. As a result, the circleci version of Node has been bumped to 4.2. If, for some reason, this should be lowered, I wouldn't be opposed to re-introducing some of the babel plugins, but only if there is a stable version that should be supported, that isn't currently.

Dist vs Lib

The final build of this package now goes into a lib folder, staying in convention that this is a library, not an application.

jmp3833 commented 8 years ago

@JRJurman LGTM. I'm going to test the npm commands locally quick to make sure there's no issues cross-environment.

jmp3833 commented 8 years ago

Everything looks good testing locally 💯 🎉