search

JRJurman / automated-ticket-printer

This project is an automated solution to print tickets and items as they get assigned.
MIT License
11 stars 1 forks source link

WIP: Add first pass at eslintrc #19

Closed jmp3833 closed 6 years ago

jmp3833 commented 8 years ago

@JRJurman Let me know if these rules are good for you, they tag some of the already implemented JS code, so I can tone down the strictness if need be.

JRJurman commented 8 years ago

I'm actually removing some es6 magic, just because babel takes forever to do installs and builds. I'm going to keep some things, and I might re-add a few as they become more obvious.

Since that isn't merged in yet (it seems mocha on my machine and circle-ci differ), I think it's safe to keep all the rules - just a heads up that this will change over time, and not remain static.

I'll review this the next time I have Wi-Fi, and can read through all the rules. @jmp3833, can we link the source for the eslintrc, or a page that lists what all the rules do in this pr?

jmp3833 commented 8 years ago

@JRJurman Added links to all rule names. Came from an old eslintrc I had been using on another project, but without any React or frontend specific rules since we're working with a lib

JRJurman commented 8 years ago

@jmp3833 Nice, thanks for the docs! I noticed that there's a merge conflict now, but it only seems to be the .gitignore... It seems to be having trouble here:

<<<<<<< HEAD
# distributables
dist/*
=======
# distributable
>>>>>>> master
lib/*

That can be changed to just

# distributable
lib/*

There's no lint command or dependency to run this, so I'm not exactly sure how to test this, or run this against CircleCI. Not sure what the convention is, but we definitely want these running in CircleCI, so maybe changing the current test override in circle.yml from this:

test:
  override:
    - npm run build && npm run test:ci

to this:

test:
  override:
    - npm run build
    - npm run test:ci
    - npm run lint

would work nicely.