search

JRJurman / new-group-nav

New Tab replacement to see tab groups and add notes
https://chrome.google.com/webstore/detail/new-group-nav/hjgdhnoigpbcegnpalbhdofoimnjganj
2 stars 0 forks source link

When expanding and collapsing pages note text resets #16

Closed JRJurman closed 2 years ago

JRJurman commented 2 years ago

When a page is collapsed or expanded, the notes in all pages reset to what they were when the new page tab was when it was first opened.

This is probably a side-effect of all the pages re-rendering when a page state changes (this can be seen in the network tab, we make new requests for all favicons on collapsing or expanding). Ideally we should only be re-rendering the page that is changing (although even if it were isolated, there is a chance that the state would reset on expanding a tab).

We should fix this so that the notes persist when the page is collapsed or expanded.

JRJurman commented 2 years ago

This was mostly fixed by #15 , but still happens for the page that is expanding or closing, should be able to resolve this by committing the note on click.

JRJurman commented 2 years ago

This has been fixed and will be included in the next release