JRavi2 / Chat-Analyzer

A python program to analyze your Social Chats

12 stars 8 forks source link

Whatsapp imported file error fixed #11

Open Prashun123 opened 2 years ago

Prashun123 commented 2 years ago

Closes #8 The error we received while using the imported file of Whatsapp is fixed, it was giving some error due to some regex expressions, but they are fixed now.

JRavi2 commented 2 years ago

@Prashun123 Thanks for the PR!

This does fix the bug, but, will also cause the program to not recognize the previous formats (try running the tests). A simple fix for this would be to make ampm optional in the Regex.

Also, while creating the dictionary maintain a separate variable for time format, and set this variable to the appropriate value depending on whether there is an ampm in match.

Finally, you can check whether the fix worked or not by running the tests :)

JRavi2 commented 2 years ago

@Prashun123 Any updates on this?

Prashun123 commented 2 years ago

Sir, there were some submissions which incorporated the date and time issue more correctly, so I thought to start work on other issue's.

JRavi2 commented 2 years ago

10 Is currently is focused on fixing the dates, you can continue working on this if you want :)