Closed anitmangal closed 2 years ago
@anitmangal Thanks for the PR! This is a nice start! Right now the results are getting printed out without much formatting. Could you change that to tabulated data? You can refer to the already implemented percentage part as an example.
Yes I will do that. I think only the 'activity' path requires the tabulated data formatting or is there something else as well?
@anitmangal Thanks for the PR! This is a nice start! Right now the results are getting printed out without much formatting. Could you change that to tabulated data? You can refer to the already implemented percentage part as an example.
Follow up on #16 and #17 addressing #5
Fixed an indentation error which allowed graph to show when not asked in activity path
Increased comprehensibility of source code
Fixed linting errors using flake8 and autopep8
This looks good!
One final thing left. Since the output for some of the options has changed, the tests need to be updated. To do that you just need to run the program for the test files and put in the updated output in the expected_res
in test.py, like here and verify that all the tests pass.
Also, no need to worry about the linting for the tests.py file.
Follow up on issue #5
Follow Up
Can you capitalize the hours_list
variable (to HOURS_LIST
)? It's considered a good convention to keep the global constants capitalized.
Follow Up
Looking all good and merging at last! Thank you for your patience! And, congrats on getting your first PR merged :tada:
Closes #5
Changed module imports: Since pyplot was no longer required in chat_functions.py, removed. Since pyplot was required in chat_analyzer.py, added import command.
Changed function 'activity' in chat_functions.py: Shifted all print and pyplot statements along with logic and related attributes to chat_analyzer.py
Changed function 'interaction_curve' in chat_functions.py: Shifted all print and pyplot statements along with logic and related attributes to chat_analyzer.py