Changes to streamline-io

[anitmangal]

Closes #5

• Changed module imports: Since pyplot was no longer required in chat_functions.py, removed. Since pyplot was required in chat_analyzer.py, added import command.

• Changed function 'activity' in chat_functions.py: Shifted all print and pyplot statements along with logic and related attributes to chat_analyzer.py

• Changed function 'interaction_curve' in chat_functions.py: Shifted all print and pyplot statements along with logic and related attributes to chat_analyzer.py

[JRavi2]

@anitmangal Thanks for the PR! This is a nice start! Right now the results are getting printed out without much formatting. Could you change that to tabulated data? You can refer to the already implemented percentage part as an example.

[anitmangal]

Yes I will do that. I think only the 'activity' path requires the tabulated data formatting or is there something else as well?

@anitmangal Thanks for the PR! This is a nice start! Right now the results are getting printed out without much formatting. Could you change that to tabulated data? You can refer to the already implemented percentage part as an example.

[JRavi2]

Also, I'd recommend running flake8 . from the src directory. This will list any linting errors. Most linting errors can be fixed by autopep8 running autopep8 -i -r . from the src directory. Others would have to be fixed manually. Both flake8 and autopep8 can be installed using pip.

[anitmangal]

Follow up on #16 and #17 addressing #5

• Fixed an indentation error which allowed graph to show when not asked in activity path

• Increased comprehensibility of source code

• Fixed linting errors using flake8 and autopep8

[JRavi2]

This looks good! One final thing left. Since the output for some of the options has changed, the tests need to be updated. To do that you just need to run the program for the test files and put in the updated output in the expected_res in test.py, like here and verify that all the tests pass.

Also, no need to worry about the linting for the tests.py file.

[anitmangal]

Follow up on issue #5

• Updated tests.py to reflect the changes done for output of chat_analyzer.py

[anitmangal]

Follow Up

• Added hours_list as a global variable from globals and implemened it in the program. [Turns out that globals.py used hours_list as global variable but the actual variable was named HOURS_LIST, fixed.]

[JRavi2]

Can you capitalize the hours_list variable (to HOURS_LIST)? It's considered a good convention to keep the global constants capitalized.

[anitmangal]

Follow Up

• Replaced hours_list with HOURS_LIST and removed temporary comments

[JRavi2]

Looking all good and merging at last! Thank you for your patience! And, congrats on getting your first PR merged :tada: