JRaviLab / MolEvolvR

An R Package for characterizing proteins using molecular evolution and phylogeny

https://jravilab.github.io/MolEvolvR/

Other

6 stars 16 forks source link

Restructured project: Moved files into case_studies/CARD, removed red… #107

Open Cateline opened 1 month ago

Cateline commented 1 month ago

…undant files from R folder

Description

What kind of change(s) are included?

[x] Feature (adds or updates new capabilities)
[x] Bug fix (fixes an issue).
[ ] Enhancement (adds functionality).
[ ] Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

[x] I have read and followed the CONTRIBUTING.md guidelines.
[x] I have searched for existing content to ensure this is not a duplicate.
[x] I have performed a self-review of these additions (including spelling, grammar, and related).
[x] I have added comments to my code to help provide understanding.
[x] I have added a test which covers the code changes found within this PR.
[x] I have deleted all non-relevant text in this pull request template.
[x] Reviewer assignment: Tag a relevant team member to review and approve the changes. @jananiravi @falquaddoomi @epbrenner @AbhirupaGhosh

Cateline commented 1 month ago

Noted. Thank you for the help🙏

On Tue, 22 Oct 2024, 01:22 Faisal Alquaddoomi, @.***> wrote:

@.**** commented on this pull request.

IMHO this looks a lot better! I see that the check is passing, too, which makes sense considering that the package itself is unchanged. I'll have to rely on someone else to review the R code in detail, but it looks reasonable to me.

If this PR replaces #103 https://github.com/JRaviLab/MolEvolvR/pull/103, I'd suggest closing that one without merging to reduce the potential for confusion.

— Reply to this email directly, view it on GitHub https://github.com/JRaviLab/MolEvolvR/pull/107#pullrequestreview-2383406742, or unsubscribe https://github.com/notifications/unsubscribe-auth/BIQBLEIJY6OKJSQMEG6WSS3Z4V5DBAVCNFSM6AAAAABQIR5UWWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOBTGQYDMNZUGI . You are receiving this because you authored the thread.Message ID: @.***>

falquaddoomi commented 1 month ago

Hey @Cateline, for future reference you can delete multiple files in a single commit; you don't need to create one commit per deletion.

Cateline commented 1 month ago

Hey @Cateline, for future reference you can delete multiple files in a single commit; you don't need to create one commit per deletion.

Oh, okay. Didn't know that. I was using the Github API to delete them

jananiravi commented 1 month ago

Agree with the broad comments of:

Cleaning up for said bug-drug combo
Rm unnecessary large files
Pooling related commits
Creating a new but related issue (tagging this issue + pr) to generalize for any new bug-drug combo (while bearing in mind companion file requirements and which of these GitHub friendly in terms of size). Could @AbhirupaGhosh @epbrenner create this new issue based on how this structured?
Guess this is the reason #103 is closed?

Any other outstanding Qs to fix/merge this issue? If so, I can look at it more carefully later this week.

Thanks, @Cateline !