JRaviLab / MolEvolvR

An R Package for characterizing proteins using molecular evolution and phylogeny
https://jravilab.github.io/MolEvolvR/
Other
6 stars 16 forks source link

R-CMD Check : selectLongestDuplicate, plotEstimatedWallTimes, removeTails, condenseRepeatedDomains, plotStackedLineage #114

Closed Klangina closed 3 weeks ago

Klangina commented 3 weeks ago

Originally posted by @the-mayer in https://github.com/JRaviLab/MolEvolvR/issues/4#issuecomment-2395224917

Klangina commented 3 weeks ago

Fixed all the warnings except:

removeTails: no visible binding for global variable ‘domains_keep’ @jananiravi @the-mayer : Need the logic for extracting domains_keep from prot, kindly guide.

the-mayer commented 3 weeks ago

As the keep_domains param defaults to FALSE, it seems like this bit of code rarely (if ever) gets evaluated. Regardless, this is a good find! I'm going to convert your comment to another issue, while merging the other changes in your PR.