JRaviLab / MolEvolvR

An R Package for characterizing proteins using molecular evolution and phylogeny
https://jravilab.github.io/MolEvolvR/
Other
6 stars 16 forks source link

This PR addresses issue #4 (format_job_args: no visible binding for global variable ‘tags’ and ‘fields_metadata’) #28

Closed SunSummoner closed 1 month ago

SunSummoner commented 1 month ago

What kind of change(s) are included?

Checklist

SunSummoner commented 1 month ago

Hi @SunSummoner,

Thank you so much for your contribution! There is a lot that works well in this PR, and I appreciate the effort you put into tackling some tricky situations in the files and functions you started with.

I have not commented on all code changes in this PR but have instead attempted to provide representative examples of where .data was used correctly and where it was not.

One thing that will help with identifying these issues more accurately is the liberal use of running devtools::check(). With this PR, many of the tricky situations where .data was applied incorrectly could have been discovered locally. I'd recommend changing a few global variable definitions, running devtools::check() and evaluating the result to see if the warning has disappeared.

Again, this is a strange issue because you will generally not notice it outside of creating an RPackage. Go ahead and attempt a few revisions and feel free to reach out with questions!

Thank you @the-mayer I'll make the required changes in the PR. I was having some issue with devtools::check() in my version of R so I'll try checking that up too.