JRaviLab / MolEvolvR

An R Package for characterizing proteins using molecular evolution and phylogeny
https://jravilab.github.io/MolEvolvR/
Other
6 stars 16 forks source link

added check gha action #32 #34

Open awasyn opened 1 month ago

awasyn commented 1 month ago

Description

The commit adds rworkflows which is a suite of tools to make it easy for R developers to implement reproducible best practices on GitHub. Check: https://github.com/neurogenomics/rworkflows Issue: https://github.com/JRaviLab/MolEvolvR/issues/32

What kind of change(s) are included?

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

awasyn commented 1 month ago

@jananiravi Can you review my PR?

awasyn commented 1 month ago

I’ve noted one change we should address in the interim. I’m not opposed to having this workflow manage building the pkgdown website, but at the moment, this check duplicates some functionality. I’d like your perspective on keeping the existing pkgdown action versus implementing the one in this PR.

I agree. The pkgdown in rworkflow can be on hold as It won't actually deploy since the checks are bound to fail as a result of incomplete function documentation.

Having the current pkgdown workflow is probably the best option to keep the site updated as changes are added.