JRaviLab / MolEvolvR

An R Package for characterizing proteins using molecular evolution and phylogeny
https://jravilab.github.io/MolEvolvR/
Other
6 stars 16 forks source link

Rename the listed function names in the following files. #44

Closed Seyi007 closed 3 weeks ago

Seyi007 commented 1 month ago
          [R/combine_analysis.R](https://github.com/JRaviLab/MolEvolvR/blob/main/R/combine_analysis.R)
Original Modified User Facing
combine_full combineFullAnalysis
combine_ipr combineIPR
R/combine_analysis.R Original Modified User Facing
combine_files combineFiles
R/create_lineage_lookup.R Original Modified User Facing
create_lineage_lookup createLineageLookup
shorten_NA shortenNA

Originally posted by @the-mayer in https://github.com/JRaviLab/MolEvolvR/issues/7#issuecomment-2395119886

All updates should follow this format: Original Modified User Facing
original_function newFunction

NOTE: Before beginning to work on a particular file, please check to see that @jananiravi has given the 👍 on the comment.

Please follow the contributing guidelines and create a new branch containing your changes. Commit your work, and submit a PR when ready for review.

Additionally, use the search in all files functionality in VS code, Rstudio, or any other text editor, and list all files the function is being called or used to be updated later.

Seyi007 commented 1 month ago

Task done!

R/combine_analysis.R

                   files found:

combine_full | Namespace, .Rd(auto-gen) combine_ipr | Namespace, .Rd

R/combine_files.R combine_files | Namespace, combine_analysis.R, .Rd

R/create_lineage_lookup.R create_lineage_lookup | Namespace, GCA2lin.Rd, ipg2lin.Rd, acc2lin.R, lineage.R shorten_NA | none (internal facing), prefixed with "."

jananiravi commented 1 month ago

@rlesiyon, please check how your createLineageLookup does compared to this function, please?

Seyi007 commented 1 month ago

Hi @jananiravi , this task has been done as stated earlier, It was included in my recent pull request.

the-mayer commented 1 month ago

@Seyi007, I'm not seeing a PR for this. Could you please confirm that the PR was created or link the PR to this issue? Thank you!

Seyi007 commented 1 month ago

I included it in the error handling functionality in the PR #76 @the-mayer